Skip to content

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Oct 21, 2024
Merged

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. #2927

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
80fcf08
Typing in long pasted text moves the cursor to the end
Ahmed-Naguib93 Oct 6, 2024
f5432f2
Move move courser to end
Ahmed-Naguib93 Oct 11, 2024
97306db
Fix issue in past text for inbox
Ahmed-Naguib93 Oct 15, 2024
73c6009
fix swiftLint issue
Ahmed-Naguib93 Oct 15, 2024
42af1cf
Fix past long text
Ahmed-Naguib93 Oct 15, 2024
92ea918
Fix indentation
Ahmed-Naguib93 Oct 15, 2024
37151a9
Fix issue in iOS18
Ahmed-Naguib93 Oct 15, 2024
294b6d6
Fix past issues
Ahmed-Naguib93 Oct 15, 2024
e444057
Fix swiftlint issues
Ahmed-Naguib93 Oct 16, 2024
15cd769
Update for CI
Ahmed-Naguib93 Oct 16, 2024
4e00178
Use textEditor instead
Ahmed-Naguib93 Oct 16, 2024
544c128
Update for CI
Ahmed-Naguib93 Oct 16, 2024
9dca192
fix conflicts
Ahmed-Naguib93 Oct 16, 2024
18d0f50
Remove white lines
Ahmed-Naguib93 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions Core/Core/Inbox/ComposeMessage/View/UITextViewWrapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,25 +30,26 @@ struct UITextViewWrapper: UIViewRepresentable {
}

func updateUIView(_ textView: UITextView, context: UIViewRepresentableContext<UITextViewWrapper>) {
textView.text = text
if text != textView.text {
textView.text = text
}
}

func makeCoordinator() -> Coordinator {
let coordinator = Coordinator(self)

return coordinator
let coordinator = Coordinator(self)
return coordinator
}

class Coordinator: NSObject, UITextViewDelegate {

var parent: UITextViewWrapper
var parent: UITextViewWrapper

init(_ textField: UITextViewWrapper) {
self.parent = textField
}
init(_ textField: UITextViewWrapper) {
self.parent = textField
}

func textViewDidChange(_ textView: UITextView) {
self.parent.text = textView.text
}
func textViewDidChange(_ textView: UITextView) {
parent.text = textView.text
}
}
}