Create To Do screen #2809

rh12 · 2024-06-05T13:54:03Z

refs: MBL-17289
affects: Student, Teacher
release note: Create ToDo screen in Calendar was updated with new visuals.

What's new

Reworked CreateToDo and SelectCalendar screens
Added loading overlay functionality to BaseScreen
Added NavigationBarButton component
Added various cells & views to InstUI
Added dynamicTypeSize environment property in most places (sizeCategory is deprecated)
Added disabled and placeholder colors to be used where customization is needed/possible
Added new & missing tests for colors & icons
Updated Xcode schemes to calculate coverage for Core

Known issues

SelectCalendar screen back button is not styled (happy to fix it if you have ideas)
TextField height bumps a little bit when it's focused (see "Add title...")
TextEditor jumps to top when it's already scrolled and some text is pasted at the bottom (only on iOS 17; iOS 16 works fine)
TextField and TextEditor doesn't defocus when tapped outside of CreateToDo screen (eg. on iPad)
When VoiceOver active tapping on bottom area of CreateToDo screen doesn't activate Details TextEditor (as it does without VoiceOver)

Test plan

Compare CreateToDo and SelectCalendar screens with Figma
Verify ToDo is created and Calendar is refreshed
Verify SelectCalendar screen doesn't show Group Calendars and sorts as expected
Verify that on CreateToDo screen the personal calendar is always selected by default

Screenshots

Before	After

Checklist

refs: MBL-17289 affects: Student, Teacher release note: none test plan: See ticket

refs: MBL-17289 affects: Student, Teacher release note: Create ToDo screen in Calendar was updated with new visuals. test plan: See ticket

inst-danger · 2024-06-05T14:16:38Z

Release Note:

Create ToDo screen in Calendar was updated with new visuals.

Affected Apps: Student, Teacher

MBL-17289

Coverage	New %	Master %	Delta
Canvas iOS	91.81%	91.68%	0.13%

Generated by 🚫 dangerJS against db235f0

inst-danger · 2024-06-05T14:21:04Z

Student Build QR Code:

inst-danger · 2024-06-05T14:22:27Z

Teacher Build QR Code:

vargaat

Went through the code and added some findings, in addition to those we talked about the icons and colors scripts usage in private. Good job in overall, especially on extending the InstUI toolset.

Core/Core/InstUI/Views/NavigationBarButton.swift

Core/Core/Planner/CreateToDo/View/SelectCalendarScreen.swift

Core/Core/Planner/CreateToDo/ViewModel/CreateToDoViewModel.swift

Core/Core/Planner/CreateToDo/ViewModel/SelectCalendarViewModel.swift

Core/Core/InstUI/Styles/Padding.swift

Core/Core/Planner/PlannerAssembly.swift

szabinst

We have now a bunch of *Cell components but are they really only used in lists? What I mean is that could they be simply named *View?

When testing for error scenarios I receive a Publishing changes from within view updates is not allowed, this will cause undefined behavior. on the CreateTodo screen.

Core/Core/InstUI/BaseScreen.swift

szabinst · 2024-06-11T11:25:41Z

Core/Core/InstUI/Views/Cells/LabelValueCell.swift

+    public struct LabelValueCell<Label: View>: View {
+        @Environment(\.dynamicTypeSize) private var dynamicTypeSize
+
+        private let label: Label
+        private let value: String?
+        private let action: () -> Void
+
+        public init(label: Label, value: String?, action: @escaping () -> Void) {
+            self.label = label
+            self.value = value
+            self.action = action
+        }


Since this component is actually a button, not just a label I think we should either change the name or change the name and make the action parameter optional.

szabinst · 2024-06-11T11:47:48Z

Core/Core/Planner/CreateToDo/ViewModel/CreateToDoViewModel.swift

+        // end of today, to match default web behaviour
+        date = .now.endOfDay()


For me this behaviour was strange, I'd expect a picker to work like other mobile app pickers. Idk if we should talk about this with Marci and Judit.

Core/Core/Planner/CreateToDo/ViewModel/CreateToDoViewModel.swift

rh12 · 2024-06-14T13:04:32Z

Code Review + 1 for Attila's changes.
Thank you both for the comments and changes!

vargaat

QA+1

rh12 added 23 commits June 5, 2024 15:52

Add CreateToDo files, organize PlannerAssembly

ac95096

refs: MBL-17289 affects: Student, Teacher release note: none test plan: See ticket

Remove unused CalendarEventDetailsViewController from Core

4db9333

Add loading overlay functionality to BaseScreen (from EditorForm)

ce8ff1d

Add NavigationBarButton to InstUI

453dd45

Add TextFieldCell

08d4062

Work on CreateToDo UI

4176908

Add NavBar button disabling

56559b0

Add Date cell

7aa9049

Improve TextFieldCell

09e2041

Add padding style sets

ae73c7e

Add InstUI.DisclosureIndicator

a5de10c

Add LabelValueCell

6b995b0

Add TextEditor cell

5e3ec1b

Improve focus-defocus behaviour

38cc452

Add RadioButtonCell

f6a0cc2

Add CalendarSelector screen

33f24dc

Refactor CalendarSelector

ccf641a

Implement adding the ToDo

702774e

Add completion

5bc6aff

Remove Group calendars from CreateToDo

516ffcb

Minor improvements

2883deb

Fix non dynamic text sizes

72df0ba

Fix VoiceOver issues

67770da

refs: MBL-17289 affects: Student, Teacher release note: Create ToDo screen in Calendar was updated with new visuals. test plan: See ticket

rh12 self-assigned this Jun 5, 2024

rh12 added 2 commits June 5, 2024 16:49

Update test

47ca01c

Remove SelectCalendar tracking, update navigation to use router

61134cd

domonkosadam mentioned this pull request Jun 7, 2024

Inbox improvements #2810

Merged

6 tasks

rh12 added 2 commits June 7, 2024 13:21

Add tests

1225396

Add new & missing tests for colors & icons

62af9a5

rh12 force-pushed the feature/MBL-17289-Create-ToDo-screen branch from 6320c4c to 62af9a5 Compare June 7, 2024 11:21

rh12 added 3 commits June 7, 2024 14:07

Update schemes to calculate coverage for Core

52f2e11

Match DatePickerCells height with other cells

ffdad68

Cleanup

06b65fc

rh12 force-pushed the feature/MBL-17289-Create-ToDo-screen branch from 5e201e3 to 06b65fc Compare June 7, 2024 12:47

rh12 marked this pull request as ready for review June 7, 2024 13:09

rh12 requested review from vargaat, balintbartok, szabinst and ndrsszsz as code owners June 7, 2024 13:09

vargaat requested changes Jun 11, 2024

View reviewed changes

szabinst reviewed Jun 11, 2024

View reviewed changes

vargaat added 6 commits June 13, 2024 14:21

Refactor radio button cell.

4bc935a

Make view models call load on their interactors.

fd73f87

Fix create todo retry not working after a failure.

9c106eb

Make nav bar button generic.

65d1aef

Move optional section header handling to InstUI component.

d95355a

Simplify padding handling.

db235f0

szabinst approved these changes Jun 14, 2024

View reviewed changes

vargaat approved these changes Jun 14, 2024

View reviewed changes

vargaat merged commit 8ea4e55 into master Jun 14, 2024

vargaat deleted the feature/MBL-17289-Create-ToDo-screen branch June 14, 2024 15:31

rh12 mentioned this pull request Oct 17, 2024

Fixed an issue where pasting long text and typing in the middle moved the cursor to the end. #2927

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Create To Do screen #2809

Create To Do screen #2809

Uh oh!

rh12 commented Jun 5, 2024 •

edited

Loading

Uh oh!

inst-danger commented Jun 5, 2024 •

edited by jira bot

Loading

Uh oh!

inst-danger commented Jun 5, 2024 •

edited

Loading

Uh oh!

inst-danger commented Jun 5, 2024 •

edited

Loading

Uh oh!

vargaat left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szabinst left a comment

Uh oh!

Uh oh!

szabinst Jun 11, 2024

Uh oh!

szabinst Jun 11, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rh12 commented Jun 14, 2024

Uh oh!

vargaat left a comment

Uh oh!

Uh oh!

		// end of today, to match default web behaviour
		date = .now.endOfDay()

Create To Do screen #2809

Create To Do screen #2809

Uh oh!

Conversation

rh12 commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What's new

Known issues

Test plan

Screenshots

Checklist

Uh oh!

inst-danger commented Jun 5, 2024 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release Note:

Affected Apps: Student, Teacher

Uh oh!

inst-danger commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

inst-danger commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vargaat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

szabinst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

szabinst Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

szabinst Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rh12 commented Jun 14, 2024

Uh oh!

vargaat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rh12 commented Jun 5, 2024 •

edited

Loading

inst-danger commented Jun 5, 2024 •

edited by jira bot

Loading

inst-danger commented Jun 5, 2024 •

edited

Loading

inst-danger commented Jun 5, 2024 •

edited

Loading