Skip to content

Conversation

domonkosadam
Copy link
Contributor

@domonkosadam domonkosadam commented Jun 7, 2024

Inbox improvements

Everything should work like expected even if it's not listed in the ticket explicitly. Important features to test:

refs: MBL-16811
affects: Student, Teacher
release note: Inbox UI update

test plan: Test all features in the Inbox.

  • Message list updates correctly
  • Filters are working properly
  • Message details screen works properly
  • All available options are working: archive/delete/mark as/star
  • Accessibility
  • Compose message
    • Context selection
    • Recipient selection
    • Individual sending
  • Included messages are shown correctly
  • Attach files
    • upload file
    • upload photo
    • take photo
    • record audio
      • record new audio
      • playback audio
      • seek in audio
    • select uploaded file
      • select from conversation attachments folder
      • select from another folder
      • navigate in file selection
  • Send/cancel composed message
  • String resources

New features

  • Arhive option
  • Mark as Read/Unread
  • Open attached files while composing a new message
  • Attach file from User's Files folder
    • Limitation: all attached files have to be in the conversation attachments folder
    • If the use choose a file from that folder it will attach to the message without uploading
    • If the user choose a file from a different folder it will upload as a duplicate to the folder
  • Audio recorder with playback and seek function
  • On cancel, on attachment remove uploaded files will be deleted from the User's File folder either
  • On reply/forward all included messages are visible with an expandable
  • Confirmation dialog on cancel

Known limitation

  • While composing a long text, cursor can move out from the screen and the user has to scroll. It will be fixed with Create To Do screen #2809 InstUI.TextFieldCell

Screenshots

BeforeAfter

Checklist

  • A11y checked
  • Tested on phone
  • Tested on tablet
  • Tested in dark mode
  • Tested in light mode
  • Approve from product

@balintbartok
Copy link
Contributor

balintbartok commented Jun 11, 2024

minor thing: pronouns seems to be missing from the address book

OldNew

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Round 2 of code review, minor things again.
Will continue

Copy link
Collaborator

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When composing a new message I found it weird that [No Subject] is just a label but not the actual input field. I was tapping it repeatedly until I found the actual subject field that is meant for entering text.

  • It would be cool to be able to dismiss the keyboard so I can re-read my message easier.

Copy link
Collaborator

@vargaat vargaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also posting some review findings. I also found that archived messages became read ones after opening them automatically.
IMG_0013

RPReplay_Final1718118604.mov

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review + 1

Copy link
Collaborator

@szabinst szabinst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

Copy link
Contributor

@ndrsszsz ndrsszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1
Tested on iPhone 11, iOS 17.4.1

Copy link
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA + 1

@domonkosadam domonkosadam merged commit 0c29865 into master Jun 18, 2024
@domonkosadam domonkosadam deleted the Inbox-improvements branch June 18, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants