-
Notifications
You must be signed in to change notification settings - Fork 122
Inbox improvements #2810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inbox improvements #2810
Conversation
refs: MBL-15941 affects: Teacher, Student release note: none test plan: See ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Round 2 of code review, minor things again.
Will continue
Core/Core/Inbox/AttachmentPicker/Model/FilePickerInteractor/FilePickerInteractorPreview.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/AttachmentPicker/Model/FilePickerInteractor/FilePickerInteractorLive.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/AttachmentPicker/Model/FilePickerInteractor/FilePickerInteractorLive.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/AttachmentPicker/ViewModel/FilePickerViewModel.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/AttachmentPicker/ViewModel/FilePickerViewModel.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/ViewModel/ComposeMessageViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
When composing a new message I found it weird that [No Subject] is just a label but not the actual input field. I was tapping it repeatedly until I found the actual subject field that is meant for entering text.
-
It would be cool to be able to dismiss the keyboard so I can re-read my message easier.
...Inbox/AttachmentPicker/Model/AttachmentPickerInteractor/AttachmentPickerInteractorLive.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/Model/ComposeMessageOptions.swift
Outdated
Show resolved
Hide resolved
Core/Core/Inbox/ComposeMessage/ViewModel/ComposeMessageViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review + 1
Core/CoreTests/Inbox/ComposeMessage/ComposeMessageInteractorLiveTests.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA +1
Tested on iPhone 11, iOS 17.4.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA + 1
Inbox improvements
Everything should work like expected even if it's not listed in the ticket explicitly. Important features to test:
refs: MBL-16811
affects: Student, Teacher
release note: Inbox UI update
test plan: Test all features in the Inbox.
New features
Known limitation
Screenshots
Checklist