Migrate to terraform plugin framework#1379
Merged
JaylonmcShan03 merged 74 commits intomainfrom Jan 16, 2025
Merged
Conversation
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
jrhouston
force-pushed
the
helm-framework
branch
from
e1bca57 to
dc432d6
Compare
JaylonmcShan03
force-pushed
the
helm-framework
branch
from
7357260 to
3663c68
Compare
…ata models. This is the current working version of the data source
* rename: helmReleaseModel -> HelmReleaseModel * tidying up during code review
* Fix acronyms in struct field names in kubeConfig.go and provider.go * Fixed acronym in kubeConfig that wasnt pushed in previous pr * Refactored debug handling to use a boolean variable * removing unnessary comment * Updating the debug two conditionals into one * Fixing edge case logic * Simpliyfing if statements * Fixing location of debug variable
…h list of objects structure (#1470)
* remove duplicate logs * refactor to use recomputeMetadata method * use Equal for version check in useChartVersion * more cleanup in useChartVersion / removing quotation removal from version * refactor valuesKnown method in ModifyPlan * remove null check in valuesKnown method * separate conditionals in recomputeMetadata * separate conditionals in valuesUnknown
…1476) * Rename resolveChartName to buildChartNameWithRepository for clarity * Updating logs to reflect the new function name change
* Refactor: Rename struct fields in HelmReleaseModel to CamelCase * Fixing overlooked field, and making the struct names in alphabetical order
add links to SDKv1 and Terraform Plugin Framework
jrhouston
approved these changes
Jan 16, 2025
BBBmau
approved these changes
Jan 16, 2025
Contributor
|
This PR seems to comment out loads of relevant and presumably important tests for resource_helm_release ... why is that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains the work to migrate this provider to Terraform Plugin Framework.
Acceptance tests
Release Note
Release note for CHANGELOG:
References
Community Note