Skip to content

Refactor: Rename SetListList to SetListSlice#1480

Merged
JaylonmcShan03 merged 1 commit intohelm-frameworkfrom
refactor/rename-setlist-to-slice
Sep 5, 2024
Merged

Refactor: Rename SetListList to SetListSlice#1480
JaylonmcShan03 merged 1 commit intohelm-frameworkfrom
refactor/rename-setlist-to-slice

Conversation

@JaylonmcShan03
Copy link

Description

This PR refactors the getTemplateValues, and getValues function by renaming the SetListList variable to SetListSlice

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

...

References

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Copy link
Collaborator

@BBBmau BBBmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@JaylonmcShan03 JaylonmcShan03 merged commit 8889b69 into helm-framework Sep 5, 2024
@JaylonmcShan03 JaylonmcShan03 deleted the refactor/rename-setlist-to-slice branch September 5, 2024 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants