-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Enhance localization of the ai-ide package #16426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ndoschek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pisv, really appreciate your continued work on the localization enhancements! 🙏
I noticed two things:
- The descriptions for the tool requests are still missing, e.g., in the following case:

These descriptions appear in the AI chat input suggestions, such as here:

- The messages defined in
packages/ai-ide/src/browser/ide-chat-welcome-message-provider.tsxare only partially localized, some html elements are localized, but most are not.
However, the current approach is a bit cumbersome since each tag needs to be localized individually which makes the code harder to read and maintain. We can of course continue improving this in a follow-up ticket to explore more maintainable solutions as there also other occurrences with the same problem.
|
@ndoschek Thanks a lot for your thorough reviews, I really appreciate it! 👍 I absolutely concur with your comments. Having said that,
Thank you! |
|
@ndoschek I'd also like to ask your opinion about a pontential follow-up regarding localization of ai-related packages. I've noticed that the |
|
Thanks @pisv for the investigation @eneufeld do you have an opinion on this? Thanks in advance! Ad 2), I'll take care of opening a follow-up. Regarding the |
Just to clarify, there is a significant difference between tool descriptions and variable/agent descriptions: tool descriptions are meant for consumption by the language model (AI), while variable/agent descriptions are not, as far as I can tell... |
|
Hi @ndoschek , @pisv
My take would be:
The only way, how we might use translations but only if we retrieve them on the fly where they are needed. But one would need to look at the i18n infrastructure. |
|
BTW, there is already a precedent in Theia that uses two separate properties for both localized and unlocalized versions of the same text: Probably, something like that could be done for tool descriptions (and may be also agent descriptions) too. But I'd suggest to have a separate issue for that. |
ndoschek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What it does
This PR provides localization enhancements for the
ai-idepackage.How to test
There are no testing steps as such. This PR is strictly about localization enhacements. Hopefully, it can be verified by reviewing the actual code changes.
Breaking changes
Review checklist
Reminder for reviewers