Skip to content

Conversation

@pisv
Copy link
Contributor

@pisv pisv commented Oct 9, 2025

What it does

This PR provides localization enhancements for the ai-chat package.

How to test

There are no testing steps as such. This PR is strictly about localization enhacements. Hopefully, it can be verified by reviewing the actual code changes.

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Oct 9, 2025
@ndoschek ndoschek self-requested a review October 15, 2025 09:32
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the upates @pisv!
Just one minor: I noticed the description of the AgentDelegationTool is not localized (as also mentioned in #16426)

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Waiting on author in PR Backlog Oct 15, 2025
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As disucssed in the linked PR, we keep that tool descriptions un-localized for now.

LGTM 👍

@github-project-automation github-project-automation bot moved this from Waiting on author to Needs merge in PR Backlog Oct 20, 2025
@ndoschek ndoschek merged commit b05b8ff into eclipse-theia:master Oct 20, 2025
10 of 11 checks passed
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Oct 20, 2025
@github-actions github-actions bot added this to the 1.66.0 milestone Oct 20, 2025
@pisv pisv deleted the l10n-ai-chat branch October 20, 2025 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants