Migrated surrounding pair scope handler #2457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev/cursorless into surroundingPairScopeHandler
pokey
reviewed
Jul 26, 2024
packages/cursorless-engine/src/languages/TreeSitterQuery/QueryCapture.ts
Show resolved
Hide resolved
pokey
reviewed
Jul 26, 2024
packages/cursorless-engine/src/languages/TreeSitterQuery/isContainedInErrorNode.ts
Outdated
Show resolved
Hide resolved
pokey
reviewed
Jul 26, 2024
There was a problem hiding this comment.
wow that disqualify stuff looks like it was a lot of work. Nice job. We should prob have some negative tests, ie that we're not disqualifying delimiters that we do want, but I think we have some tests for those and this PR is growing long in the tooth so I'd be happy to leave those for now.
As discussed, let's drive this for a couple days and then ship it
It was definitely some effort. We have a few tests. If anything comes to mind please record a few. Otherwise I would like to just get this in at the stage. |
|
I wonder if we should make iteration scope be "line". I think being able to say "first string" / "last string" will be really useful |
Why not? |
pokey
reviewed
Jul 26, 2024
pokey
approved these changes
Jul 28, 2024
cursorless-bot
pushed a commit
that referenced
this pull request
Jul 28, 2024
Fixes #2316 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [/] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet - [x] Add `@disqualifyDelimiter` for all languages - [x] Add plural form of surrounding pair [scopes.py](https://github.com/cursorless-dev/cursorless/blob/5e9a2e955570cb43d5d07de8c861365e8361cc36/cursorless-talon/src/modifiers/scopes.py#L48) - [x] Run talon tests - [x] add multiline quad tests for plaintext? --------- Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Pokey Rule <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
As per https://www.cursorless.org/docs/contributing/test-case-recorder/#partially-upgrading-fixtures ``` pnpm transform-recorded-tests --upgrade --minimum-version 6 ``` Now that they're more than a year old, we can upgrade test fixtures so they know about destinations If merge conflicts with #2457 are going to be annoying, we can hold off until then to merge ## Checklist - [-] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [-] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [-] I have not broken the cheatsheet
This was referenced Aug 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 4, 2024
…#2626) These are now deprecated and now error out after #2457. We missed this reference in the documentation. Fixes #2625 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet
cursorless-bot
pushed a commit
to cursorless-dev/cursorless-talon
that referenced
this pull request
Aug 4, 2024
… (#2626) These are now deprecated and now error out after cursorless-dev/cursorless#2457. We missed this reference in the documentation. Fixes #2625 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet
cursorless-bot
pushed a commit
that referenced
this pull request
Aug 4, 2024
…#2626) These are now deprecated and now error out after #2457. We missed this reference in the documentation. Fixes #2625 ## Checklist - [/] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [/] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2316
Checklist
@disqualifyDelimiterfor all languages