Upgrade test fixtures to v6 #2559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but yeah please wait. #2457 is ready for review now. |
pokey
force-pushed
the
pokey/upgrade-test-fixtures-to-v6
branch
from
0c2627a to
e5f1a38
Compare
|
We should be able to merge now that #2457 is merged |
AndreasArvidsson
approved these changes
Jul 30, 2024
|
Nice that we are now just one version away from the latest. We really have reduced the cadence of our api changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://www.cursorless.org/docs/contributing/test-case-recorder/#partially-upgrading-fixtures
Now that they're more than a year old, we can upgrade test fixtures so they know about destinations
If merge conflicts with #2457 are going to be annoying, we can hold off until then to merge
Checklist