Skip to content

Remove references to left and right in surrounding pair documentation #2626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Aug 3, 2024

These are now deprecated and now error out after #2457. We missed this reference in the documentation.

Fixes #2625

Checklist

  • [/] I have added tests
  • I have updated the docs and cheatsheet
  • [/] I have not broken the cheatsheet

@AndreasArvidsson AndreasArvidsson requested a review from a team as a code owner August 3, 2024 23:14
Copy link
Member

@phillco phillco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing for now is fine, but should we file an issue to see if we can replace these suggestions with next and previous?

@AndreasArvidsson AndreasArvidsson added this pull request to the merge queue Aug 4, 2024
@AndreasArvidsson
Copy link
Member Author

I'm not sure we need that; we already have documentation for previous and next and they are not surrounding pair specific. Left and right were just documented here because they only worked with surrounding pairs.

Merged via the queue into main with commit 91a2d8f Aug 4, 2024
15 checks passed
@AndreasArvidsson AndreasArvidsson deleted the srLeftRightDocs branch August 4, 2024 07:34
cursorless-bot pushed a commit that referenced this pull request Aug 4, 2024
…#2626)

These are now deprecated and now error out after
#2457. We missed this
reference in the documentation.

Fixes #2625

## Checklist

- [/] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [x] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [/] I have not broken the cheatsheet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs reference deprecated left/right grammar for surrounding pairs
2 participants