feat: deprecate x/params usage in x/mint

[alexanderbez]

Description

Deprecate the usage of the now legacy x/params module within x/mint.

• Remove usage of x/params functionality and implementation within x/mint. Note, there is zero dependency on x/params now apart from types/params_legacy and exported/, which should be removed after the next major release. These are only needed for migrations.
• Introduce a new message type with an authority expected to be the x/gov module account that will execute the new MsgUpdateParams message.
• Updated codec
• Added migration

closes: #12286

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

what's the reasoning for supporting legacy amino?

[tac0turtle]

LGTM, seems you are missing a query to see the params, also this would be a good PR to start introducing a upgrading.md file. Any chances you can knock it out quickly

[julienrbrt]

also this would be a good PR to start introducing a upgrading.md file.

My PR for the upgrading.md is coming tomorrow, sorry about the delay 🙈

[codecov]

Codecov Report

Merging #12363 (828fcf2) into main (61dc023) will decrease coverage by 0.38%.
The diff coverage is 64.56%.

@@            Coverage Diff             @@
##             main   #12363      +/-   ##
==========================================
- Coverage   66.04%   65.65%   -0.39%     
==========================================
  Files         692      683       -9     
  Lines       72603    71549    -1054     
==========================================
- Hits        47949    46977     -972     
+ Misses      21984    21929      -55     
+ Partials     2670     2643      -27     

Impacted Files	Coverage Δ
x/mint/types/msgs.go	0.00% <0.00%> (ø)
x/mint/types/params.go	7.75% <0.00%> (+0.67%)	⬆️
x/mint/types/params_legacy.go	0.00% <0.00%> (ø)
x/mint/types/codec.go	63.15% <58.82%> (-36.85%)	⬇️
x/mint/keeper/migrator.go	71.42% <71.42%> (ø)
x/mint/migrations/v2/migrate.go	72.72% <72.72%> (ø)
x/mint/keeper/keeper.go	76.78% <80.76%> (-1.00%)	⬇️
x/mint/module.go	58.33% <88.00%> (+7.68%)	⬆️
x/mint/keeper/msg_server.go	100.00% <100.00%> (ø)
x/upgrade/types/codec.go	100.00% <100.00%> (ø)
... and 17 more

[alexanderbez]

LGTM, seems you are missing a query to see the params, also this would be a good PR to start introducing a upgrading.md file. Any chances you can knock it out quickly

No it's not because the API layer remains unchanged -- all that changed was the storage and management mechanism. From the user's PoV nothing changed. This applies to all modules.