-
Notifications
You must be signed in to change notification settings - Fork 251
Clean up deprecated cosmos-sdk 0.46 API usage #8803
Copy link
Copy link
Open
Labels
Description
What is the Problem Being Solved?
Cosmos-sdk has marked a number of the APIs we're using as "deprecated". See the 0.46 upgrade notes. While we're not forced to change the API usage until we do a cosmos-sdk upgrade to a version where the legacy compatibility is actually removed, doing so will exacerbate an already difficult migration process. We can break up the migration effort by cleaning up deprecated interfaces early.
Description of the Design
We want to make the following changes:
- change
sdk.Intandsdk.Uintto use their new location in themathpackage; - use
x/errorsinstead oftypes/errors; - module-native parameter get/set instead of
x/params. See the mint module's migration for example. - the
x/govmodule has a newv1API; - our custom
Coinsmin and max methods can be dropped in favor of the built-in version.
Security Considerations
N/A - these changes typically replace use of forwarding placeholders or identical implementations.
Scaling Considerations
N/A
Test Plan
N/A
Upgrade Considerations
N/A
Reactions are currently unavailable