Refactor/predicates include exclude

[ccamel]

Purpose

Implements #313. With this implementation, one can specifies a predicates_blacklist of predicates to exclude from the set of registered predicates that the Interpreter can use. In addition, theregistered_predicates parameter is renamed to predicates_whitelist for consistency.

Implementation details

• The blacklist is always applied after the whitelist to ensure that blacklisted predicates prevail on whitelisted predicates.
• The predicates are specified as a list of <predicate_name>/[<arity>] strings. If a predicate name without arity is included in this list, then all predicates with that name will be considered regardless of arity.

Consideration

⚠️ This PR introduces a breaking change due to the renaming of a property in the proto. The code that performs the migration v2 to v3 is included in the PR.

Todo

• specify proto
• implement feature
• add tests
• implement migration

[bdeneux]

@ccamel The migration wasn't working since paramspace is immediately initialized with the new params key table at the keeper instantiation before the migration run. Even with a legacy param subspace, we cannot change the registered key table (with the old one) at the migration step. So it impossible to get the old ParamsSet before migration to update it.

Otherwise the x/param module has been deprecated since 0.46.X so I took advantage of this migration to migrate also the ParamSet to move params into the module state. I've followed recommandation given in the cosmos changelog and the mint module PR given by cosmos. I've introduce the UpdateParams msg to give us the possibility of update module params by governance.

FYI @amimart.

[ccamel]

@bdeneux This is excellent! Thanks for the improvement.

[amimart]

Excellent! Everything seems fine 😉

[bdeneux]

Here my test to check if everything work 😜 :

• query logic params (through CLI)
• query logic ask (CLI)
• migration from old x/param to module state and new renamed params
• update new params through a "@type": "/logic.v1beta2.MsgUpdateParams" governance proposal

All good 👍 thank :)

[ccamel]

All right! Thanks so much guys. ❤️

[bot-anik]

🎉 This PR is included in version 5.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀