-
Notifications
You must be signed in to change notification settings - Fork 2
Issue #53: updated test report and upperEll to use 1 based index #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,109 +1,109 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<checkstyle version="10.12.3"> | ||
<file name="org/checkstyle/autofix/recipe/upperell/stringandcomments/InputStringAndComments.java"> | ||
<error line="11" column="30" severity="error" | ||
<error line="11" column="31" severity="error" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: We need to finish with integration test pipeline asap to get rid of these manual report files and fully rely on actual checkstyle execution and report There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yep, this is the way forward. |
||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="18" column="21" severity="error" | ||
<error line="18" column="22" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
</file> | ||
|
||
<file name="org/checkstyle/autofix/recipe/upperell/hexoctalliteral/InputHexOctalLiteral.java"> | ||
<error line="4" column="28" severity="error" | ||
<error line="4" column="29" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="5" column="28" severity="error" | ||
<error line="5" column="29" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="6" column="25" severity="error" | ||
<error line="6" column="26" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="7" column="26" severity="error" | ||
<error line="7" column="27" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="8" column="27" severity="error" | ||
<error line="8" column="28" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="11" column="25" severity="error" | ||
<error line="11" column="26" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="12" column="27" severity="error" | ||
<error line="12" column="28" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="13" column="28" severity="error" | ||
<error line="13" column="29" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
</file> | ||
|
||
<file name="org/checkstyle/autofix/recipe/upperell/complexlongliterals/InputComplexLongLiterals.java"> | ||
<error line="4" column="35" severity="error" | ||
<error line="4" column="36" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="5" column="39" severity="error" | ||
<error line="5" column="40" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="7" column="27" severity="error" | ||
<error line="7" column="28" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="8" column="27" severity="error" | ||
<error line="8" column="29" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="11" column="30" severity="error" | ||
<error line="11" column="31" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="12" column="32" severity="error" | ||
<error line="12" column="34" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="13" column="34" severity="error" | ||
<error line="13" column="35" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="18" column="33" severity="error" | ||
<error line="18" column="34" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="22" column="57" severity="error" | ||
<error line="22" column="58" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="23" column="32" severity="error" | ||
<error line="23" column="33" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="23" column="36" severity="error" | ||
<error line="23" column="37" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="23" column="40" severity="error" | ||
<error line="23" column="41" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="27" column="39" severity="error" | ||
<error line="27" column="40" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="27" column="45" severity="error" | ||
<error line="27" column="46" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="27" column="51" severity="error" | ||
<error line="27" column="52" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="32" column="17" severity="error" | ||
<error line="32" column="18" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="33" column="30" severity="error" | ||
<error line="33" column="31" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="34" column="26" severity="error" | ||
<error line="34" column="27" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="36" column="45" severity="error" | ||
<error line="36" column="46" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="37" column="41" severity="error" | ||
<error line="37" column="42" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="38" column="33" severity="error" | ||
<error line="38" column="34" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="43" column="19" severity="error" | ||
<error line="43" column="20" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
<error line="45" column="23" severity="error" | ||
<error line="45" column="24" severity="error" | ||
message="Use uppercase 'L' for long literals." | ||
source="com.puppycrawl.tools.checkstyle.checks.UpperEllCheck"/> | ||
</file> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this
false negative
comment, please clarify what you meant?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these literals are not fixed by the recipe, due to improper column calculation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please confirm this will be fixed by #56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it will do.