Skip to content

Issue #55: updated computeColumnPosition #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Anmol202005
Copy link
Collaborator

Fixes: #55
Updated method to count and add symbol characters to the base column offset calculation.

follow up of: #54

@rdiachenko
Copy link
Collaborator

rdiachenko commented Jul 19, 2025

@Anmol202005 please resolve conflicts and make sure this case is fixed #54 (comment)

@Anmol202005
Copy link
Collaborator Author

@Anmol202005 please resolve conflicts and make sure this case is fixed #54 (comment)

@rdiachenko Done,

Copy link
Collaborator

@timurt timurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect column position calculation for literals containing symbols
3 participants