Issue #53: updated test report and upperEll to use 1 based index #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue for false-negative: #55 |
rdiachenko
reviewed
Jul 19, 2025
| @@ -5,11 +5,11 @@ public class InputComplexLongLiterals { | |||
| private long multipleUnderscores = 1_234_567_890l; | |||
|
|
|||
| private long maxLong = 9223372036854775807l; | |||
| private long minLong = -9223372036854775808l; | |||
| private long minLong = -9223372036854775808l; //false negative | |||
There was a problem hiding this comment.
I don't understand this false negative comment, please clarify what you meant?
There was a problem hiding this comment.
these literals are not fixed by the recipe, due to improper column calculation.
There was a problem hiding this comment.
please confirm this will be fixed by #56
There was a problem hiding this comment.
yes, it will do.
| @@ -1,109 +1,109 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <checkstyle version="10.12.3"> | |||
| <file name="org/checkstyle/autofix/recipe/upperell/stringandcomments/InputStringAndComments.java"> | |||
| <error line="11" column="30" severity="error" | |||
| <error line="11" column="31" severity="error" | |||
There was a problem hiding this comment.
Note: We need to finish with integration test pipeline asap to get rid of these manual report files and fully rely on actual checkstyle execution and report
There was a problem hiding this comment.
yep, this is the way forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #53
updated recipe to use 1 based index.