Skip to content

Fix aws-lc-rs CI test (again) #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Mar 12, 2025

Description of changes:

  • Consolidate the aws-lc-rs CI tests.
  • Perform a "cargo clean" prior generating bindings. (Fixes Windows attempting to link to the "no-prefix" build of the library.)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title Clean before building again Fix aws-lc-rs CI test (again) Mar 12, 2025
@justsmth justsmth changed the title Fix aws-lc-rs CI test (again) [DRAFT] Fix aws-lc-rs CI test (again) Mar 12, 2025
@justsmth justsmth force-pushed the fix-aws-lc-rs-ci-again branch 3 times, most recently from ad9e71e to e97f98c Compare March 12, 2025 22:16
@justsmth justsmth force-pushed the fix-aws-lc-rs-ci-again branch from e97f98c to fac50f9 Compare March 12, 2025 22:23
@justsmth justsmth changed the title [DRAFT] Fix aws-lc-rs CI test (again) Fix aws-lc-rs CI test (again) Mar 12, 2025
@justsmth justsmth marked this pull request as ready for review March 12, 2025 22:38
@justsmth justsmth requested a review from a team as a code owner March 12, 2025 22:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.03%. Comparing base (8d77e4c) to head (fac50f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2268      +/-   ##
==========================================
- Coverage   79.04%   79.03%   -0.01%     
==========================================
  Files         612      612              
  Lines      106588   106630      +42     
  Branches    15083    15099      +16     
==========================================
+ Hits        84252    84277      +25     
- Misses      21684    21700      +16     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@justsmth justsmth merged commit 087fdc0 into aws:main Mar 13, 2025
104 of 107 checks passed
@justsmth justsmth deleted the fix-aws-lc-rs-ci-again branch March 13, 2025 00:06
@skmcgrail skmcgrail mentioned this pull request Mar 13, 2025
skmcgrail added a commit that referenced this pull request Mar 13, 2025
## What's Changed
* Use unsigned return type for BN_get_minimal_width and word size tests
by @torben-hansen in #2260
* Revert removal of "PEM_X509_INFO_write_bio" by @smittals2 in
#2226
* Remove no-op register move from ChaCha20_ctr32_ssse3_4x by @nebeid in
#2234
* Fix aws-lc-rs CI test when symbols removed by @justsmth in
#2262
* Add x4 batched SHAKE128 and SHAKE256 APIs by @manastasova in
#2247
* Fix aws-lc-rs CI test (again) by @justsmth in
#2268
* Minor build fixes for CMake and libssl on x86 by @skmcgrail in
#2267

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants