Skip to content

Minor build fixes for CMake and libssl on x86 #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

skmcgrail
Copy link
Member

@skmcgrail skmcgrail commented Mar 12, 2025

Description of changes:

  • Removes unnecessary variable evaluation in a handful of if statements for CMAKE_SYSTEM_PROCESSOR_LOWER. These can result in a failure if CMAKE_SYSTEM_PROCESSOR_LOWER is an empty string as the ${} is expanded first in the if-statement due to historical reasons.
  • libssl can fail to compile if building on x86 since we don't pass -msse2 to the C++ compiler. This is due to the fact that the crypto/internal.h is included by libssl and it explicitly checks for SSE2 support. See https://github.com/aws/aws-lc/blob/main/crypto/internal.h#L203-L214

Testing

  • Verified build with a modified ./util/32-bit-toolchain.cmake that only sets -m32 (since building on an x86-64 platform).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@skmcgrail skmcgrail requested a review from a team as a code owner March 12, 2025 21:43
@skmcgrail skmcgrail requested a review from justsmth March 12, 2025 21:43
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.04%. Comparing base (8d77e4c) to head (d757ad7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   79.04%   79.04%   -0.01%     
==========================================
  Files         612      612              
  Lines      106588   106630      +42     
  Branches    15083    15098      +15     
==========================================
+ Hits        84252    84281      +29     
- Misses      21684    21696      +12     
- Partials      652      653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

justsmth
justsmth previously approved these changes Mar 12, 2025
@justsmth justsmth merged commit d14347d into aws:main Mar 13, 2025
105 of 107 checks passed
@skmcgrail skmcgrail mentioned this pull request Mar 13, 2025
skmcgrail added a commit that referenced this pull request Mar 13, 2025
## What's Changed
* Use unsigned return type for BN_get_minimal_width and word size tests
by @torben-hansen in #2260
* Revert removal of "PEM_X509_INFO_write_bio" by @smittals2 in
#2226
* Remove no-op register move from ChaCha20_ctr32_ssse3_4x by @nebeid in
#2234
* Fix aws-lc-rs CI test when symbols removed by @justsmth in
#2262
* Add x4 batched SHAKE128 and SHAKE256 APIs by @manastasova in
#2247
* Fix aws-lc-rs CI test (again) by @justsmth in
#2268
* Minor build fixes for CMake and libssl on x86 by @skmcgrail in
#2267

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license and the ISC license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants