Minor build fixes for CMake and libssl on x86 #2267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
CMAKE_SYSTEM_PROCESSOR_LOWER
. These can result in a failure ifCMAKE_SYSTEM_PROCESSOR_LOWER
is an empty string as the${}
is expanded first in the if-statement due to historical reasons.libssl
can fail to compile if building on x86 since we don't pass-msse2
to the C++ compiler. This is due to the fact that thecrypto/internal.h
is included by libssl and it explicitly checks for SSE2 support. See https://github.com/aws/aws-lc/blob/main/crypto/internal.h#L203-L214Testing
./util/32-bit-toolchain.cmake
that only sets-m32
(since building on an x86-64 platform).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.