Remove no-op register move from ChaCha20_ctr32_ssse3_4x #2234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torben-hansen
approved these changes
Mar 4, 2025
justsmth
approved these changes
Mar 5, 2025
r11 does not have anything in it yet, and r10 is never read. This is a remnant of the ia32cap dispatch that we missed in f5e0c8f92a22679b0cd8d24d0d670769c1cc07f3. Bug: 673 Change-Id: I5cc179401418aee6479b4a38ae1c09f68ec40238 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68291 Commit-Queue: David Benjamin <[email protected]> Reviewed-by: Bob Beck <[email protected]> (cherry picked from commit 03d1b7c544851d9f44df1e9ff21839742e08c819)
nebeid
force-pushed
the
upstream-03d1b7c
branch
from
efe6f44 to
a854722
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2234 +/- ##
=======================================
Coverage 79.01% 79.02%
=======================================
Files 612 612
Lines 106589 106588 -1
Branches 15083 15084 +1
=======================================
+ Hits 84225 84233 +8
+ Misses 21711 21701 -10
- Partials 653 654 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
skmcgrail
added a commit
that referenced
this pull request
Mar 13, 2025
## What's Changed * Use unsigned return type for BN_get_minimal_width and word size tests by @torben-hansen in #2260 * Revert removal of "PEM_X509_INFO_write_bio" by @smittals2 in #2226 * Remove no-op register move from ChaCha20_ctr32_ssse3_4x by @nebeid in #2234 * Fix aws-lc-rs CI test when symbols removed by @justsmth in #2262 * Add x4 batched SHAKE128 and SHAKE256 APIs by @manastasova in #2247 * Fix aws-lc-rs CI test (again) by @justsmth in #2268 * Minor build fixes for CMake and libssl on x86 by @skmcgrail in #2267 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r11 does not have anything in it yet, and r10 is never read. This is a remnant of the ia32cap dispatch that we missed in
f5e0c8f92a22679b0cd8d24d0d670769c1cc07f3.
Bug: 673
Change-Id: I5cc179401418aee6479b4a38ae1c09f68ec40238 Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/68291
Commit-Queue: David Benjamin [email protected]
Reviewed-by: Bob Beck [email protected]
(cherry picked from commit 03d1b7c544851d9f44df1e9ff21839742e08c819)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.