Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Fixed SQL Lab Query Search scrolling issue(#7526) (#7674)#137

Merged
etr2460 merged 1 commit intoairbnb-masterfrom
erik-ritter--query-search-scroll
Jul 11, 2019
Merged

Fixed SQL Lab Query Search scrolling issue(#7526) (#7674)#137
etr2460 merged 1 commit intoairbnb-masterfrom
erik-ritter--query-search-scroll

Conversation

@etr2460
Copy link
Copy Markdown
Collaborator

@etr2460 etr2460 commented Jul 11, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Cherrypick apache#7674

TEST PLAN

make sure you can scroll in query search

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@graceguo-supercat @michellethomas

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #137 into airbnb-master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           airbnb-master     #137   +/-   ##
==============================================
  Coverage          65.16%   65.16%           
==============================================
  Files                427      427           
  Lines              20680    20680           
  Branches            2312     2312           
==============================================
  Hits               13477    13477           
  Misses              7079     7079           
  Partials             124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc272b...0d66775. Read the comment docs.

Copy link
Copy Markdown
Collaborator

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@etr2460 etr2460 merged commit 09dd3c3 into airbnb-master Jul 11, 2019
@john-bodley john-bodley deleted the erik-ritter--query-search-scroll branch December 4, 2019 02:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants