Skip to content

Control flow support #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 27, 2022
Merged

Control flow support #107

merged 21 commits into from
Jan 27, 2022

Conversation

KDr2
Copy link
Member

@KDr2 KDr2 commented Jan 23, 2022

Implement #96.

@KDr2 KDr2 requested a review from yebai January 23, 2022 05:18
phipsgabler
phipsgabler reviewed Jan 23, 2022
View reviewed changes
@yebai yebai mentioned this pull request Jan 23, 2022
Merged
rikhuijzer
rikhuijzer reviewed Jan 24, 2022
View reviewed changes
Copy link
Contributor

@rikhuijzer rikhuijzer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The integration tests of #106 and #109 are not enabled for this PR which can be seen by looking at the running time for the integration tests. Running all tests takes longer than 1 minute.

@yebai @rikhuijzer
Update CI scripts (#111)
4bc64a9 
* Add refs to integration tests (#106)

* Add refs to integration tests

* Update .github/workflows/IntegrationTest.yml

Co-authored-by: Hong Ge <[email protected]>

* Update IntegrationTest.yml (#109)

Co-authored-by: Rik Huijzer <[email protected]>
@delete-merged-branch delete-merged-branch bot deleted the branch master January 24, 2022 10:55
@KDr2
Copy link
Member Author

KDr2 commented Jan 24, 2022

Oh my, who deleted the master branch? 🤕

@yebai
Copy link
Member

yebai commented Jan 24, 2022

Oh my, who deleted the master branch? 🤕

Fixed - it was deleted by merge-bot because I merged a PR from master to this PR. I also added protection so this won't happen in the future.

KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
KDr2
KDr2 commented Jan 25, 2022
View reviewed changes
@yebai yebai mentioned this pull request Jan 25, 2022
Merged
yebai
yebai requested changes Jan 26, 2022
View reviewed changes
Copy link
Member

@yebai yebai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @KDr2 - I took another careful look. See below for comments.

@yebai yebai mentioned this pull request Jan 26, 2022
Closed
@KDr2 KDr2 requested a review from yebai January 27, 2022 02:46
@yebai yebai merged commit 679de09 into master Jan 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the ctrl-flow branch January 27, 2022 08:40
This was referenced Feb 3, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phipsgabler phipsgabler phipsgabler left review comments

@rikhuijzer rikhuijzer rikhuijzer left review comments

@yebai yebai yebai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KDr2 @yebai @phipsgabler @rikhuijzer