Add refs to integration tests #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpfiffer
approved these changes
Jan 22, 2022
|
Maybe open an issue that reminds us to revert this change once these packages are updated? |
yebai
reviewed
Jan 23, 2022
yebai
approved these changes
Jan 23, 2022
|
Thanks @rikhuijzer! |
This was referenced Jan 23, 2022
yebai
added a commit
that referenced
this pull request
Jan 24, 2022
* Add refs to integration tests (#106) * Add refs to integration tests * Update .github/workflows/IntegrationTest.yml Co-authored-by: Hong Ge <[email protected]> * Update IntegrationTest.yml (#109) Co-authored-by: Rik Huijzer <[email protected]>
yebai
added a commit
that referenced
this pull request
Jan 27, 2022
* control flow support * revert the infinite loops * bugfix * Update CI scripts (#111) * Add refs to integration tests (#106) * Add refs to integration tests * Update .github/workflows/IntegrationTest.yml Co-authored-by: Hong Ge <[email protected]> * Update IntegrationTest.yml (#109) Co-authored-by: Rik Huijzer <[email protected]> * revise types * Update IntegrationTest.yml * Update BenchmarksAndMicroIntegration.yml * only try to eval Symbol and GlobalRef * refactor * fix Turing branch * Update IntegrationTest.yml * minor update * remove used var * code refactor * remove `step_in`, move copying functions * fix perf code * move cache mechanism into TapedFunction's constructor * Update Project.toml Co-authored-by: Hong Ge <[email protected]> Co-authored-by: Rik Huijzer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, the tests are actually executed instead of skipped in the
try catchblock due to incompatible versions. But, I also understand now that it's hard to do integration tests when changes need to be made at two repositories. Anyway, adding the integration tests here is nice because it's now easier to see what needs to be done and for the reviewer to see what the current status is.