-
Notifications
You must be signed in to change notification settings - Fork 10
Tape instruction #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tape instruction #100
Conversation
0170008
to
b739b58
Compare
I test AdvancedPS against this change: TuringLang/AdvancedPS.jl@9d7debf, it got a numeric error. UPDATE: |
@KDr2 can you update the Turing PR (TuringLang/Turing.jl#1744), and see whether this works there? |
I am on it now, it has some deeper issues, I haven't find the root cause yet. |
One of them seems to be an issue of IRTools, but I am not very sure yet:
|
Varargs needs some special manipulation, I (hopefully suppose that) had fixed that. But, there're still issues, one of which is dynamic branches, e.g., https://github.com/TuringLang/DynamicPPL.jl/blob/v0.16.2/src/model.jl#L387 |
There are also some dynamically generated (by macro expanding or other facilities) functions, which we can't trace into. |
And, there are too many branches on the way by which we trace down into a deep So maybe we should support braches before we use it in Turing. |
06477d1
to
9883cc3
Compare
a63e30d
to
09d90e8
Compare
Try to implement #99.