Skip to content

Insertion of phrases without translation in pt-BR#22075

Merged
allouis merged 11 commits intoTryGhost:mainfrom
matribeiro15:main
Feb 5, 2025
Merged

Insertion of phrases without translation in pt-BR#22075
allouis merged 11 commits intoTryGhost:mainfrom
matribeiro15:main

Conversation

@matribeiro15
Copy link
Copy Markdown
Contributor

In this PR, I've inserted the phrases that were missing in pt-BR and replaced Jamie Larson with Cris Silva

Added pt-BR translation "Sort by"
Changes:
1. Hide, I used the term "ocultar" instead of "esconder",
2. Expertise for "sua especialidade",
3. Delete is changed to the term "excluir" and not "deletar"
4. Jamie Larson": "Nome e Sobrenome", avoiding the use of gender or terms that may be derogatory.
5. Show, I adjusted the term from "mostrar" to "exibir"
Jamie Larson to Cris Silva
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 29, 2025

Walkthrough

This pull request focuses on updating Portuguese (Brazil) localization files for the Ghost platform. The changes primarily involve adding missing translations and refining existing translations in two JSON files: comments.json and portal.json. The updates enhance the clarity and completeness of Portuguese language support, including translations for comment-related actions, user interface messages, and general system notifications.

Changes

File Change Summary
ghost/i18n/locales/pt-BR/comments.json - Added translations for phrases like "Are you sure?", "Delete", "Hide", and "Show"
- Updated translations for comment-related actions
- Replaced name "Jamie Larson" with "Cris Silva"
ghost/i18n/locales/pt-BR/portal.json - Added translations for preference update messages
- Updated system messages related to signups and email domains
- Replaced name and email references for "Jamie Larson"

Suggested labels

affects:i18n

Suggested reviewers

  • cathysarisky

Possibly related PRs

  • Add missing Scottish Gaelic translations #21979: The changes in this PR involve updates to the comments.json file for Scottish Gaelic, including translations for phrases like "Are you sure?" and "Deleted," which are similar to the modifications made in the main PR for Portuguese translations in the same file.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b3a097c and 6f85b06.

📒 Files selected for processing (2)
  • ghost/i18n/locales/pt-BR/comments.json (2 hunks)
  • ghost/i18n/locales/pt-BR/portal.json (6 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • ghost/i18n/locales/pt-BR/comments.json
  • ghost/i18n/locales/pt-BR/portal.json
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Regression tests (Node 20.11.1, sqlite3)
  • GitHub Check: Database tests (Node 20.11.1, sqlite3)
  • GitHub Check: Regression tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
  • GitHub Check: Lint
  • GitHub Check: i18n

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 048f177 and b3a097c.

📒 Files selected for processing (2)
  • ghost/i18n/locales/pt-BR/comments.json (2 hunks)
  • ghost/i18n/locales/pt-BR/portal.json (5 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (10)
  • GitHub Check: Ghost-CLI tests
  • GitHub Check: Unit tests (Node 20.11.1)
  • GitHub Check: Regression tests (Node 20.11.1, sqlite3)
  • GitHub Check: Unit tests (Node 18.12.1)
  • GitHub Check: Regression tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 20.11.1, sqlite3)
  • GitHub Check: Database tests (Node 20.11.1, mysql8)
  • GitHub Check: Database tests (Node 18.12.1, mysql8)
  • GitHub Check: Lint
  • GitHub Check: i18n
🔇 Additional comments (4)
ghost/i18n/locales/pt-BR/comments.json (2)

9-9: LGTM! Good translation that maintains the original meaning.

The translation accurately conveys the concept of expertise ("especialidade") in a way that sounds natural in Brazilian Portuguese.


35-35: Verify name change consistency across the application.

The name "Jamie Larson" has been changed to "Cris Silva". This change appears in both localization files.

ghost/i18n/locales/pt-BR/portal.json (2)

100-101: LGTM! Consistent name and email changes.

The name "Jamie Larson" and associated email have been consistently changed to "Cris Silva" and "cris.silva@email.com" respectively.


171-172: LGTM! Clear and accurate translations.

The translations for these messages are accurate and maintain a natural flow in Brazilian Portuguese.

matribeiro15 and others added 3 commits January 29, 2025 13:21
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Cathy Sarisky <42299862+cathysarisky@users.noreply.github.com>
Copy link
Copy Markdown
Member

@cathysarisky cathysarisky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ready to merge

@zenditimo
Copy link
Copy Markdown
Contributor

All good ;)

Co-authored-by: Timothée Zendi <zenditimothee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants