Added Hungarian locale for Portal#21982
Conversation
WalkthroughThis pull request updates the Hungarian localization files across multiple components of the application. In the Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (3)
ghost/i18n/locales/hu v2/newsletter.json (2)
22-22: Remove trailing whitespace.The Hungarian translation contains an extra space at the end which should be removed.
- "Your subscription will expire on {date}.": "Az előfizetésed ekkor fog lejárni: {date}. ", + "Your subscription will expire on {date}.": "Az előfizetésed ekkor fog lejárni: {date}.",
18-18: Consider standardizing placeholder style.The translation uses two different placeholder styles:
%%{status}%%and{site}. Consider standardizing to use curly braces consistently if possible.ghost/i18n/locales/hu v2/comments.json (1)
29-31: Consider localizing example company names.For better localization, consider using Hungarian company examples instead of "Acme Inc".
- "Founder @ Acme Inc": "A(z) @ Acme Kft. alapítója", + "Founder @ Acme Inc": "A(z) @ Magyar Kft. alapítója", - "Head of Marketing at Acme, Inc": "Marketingvezető —\u00a0Acme Kft.", + "Head of Marketing at Acme, Inc": "Marketingvezető —\u00a0Magyar Kft.",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
ghost/i18n/locales/hu v2/comments.json(1 hunks)ghost/i18n/locales/hu v2/ghost.json(1 hunks)ghost/i18n/locales/hu v2/newsletter.json(1 hunks)ghost/i18n/locales/hu v2/portal.json(1 hunks)ghost/i18n/locales/hu v2/search.json(1 hunks)ghost/i18n/locales/hu v2/signup-form.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- ghost/i18n/locales/hu v2/search.json
- ghost/i18n/locales/hu v2/signup-form.json
🔇 Additional comments (2)
ghost/i18n/locales/hu v2/ghost.json (1)
1-34: Excellent work on the translations!The translations are well done with:
- Consistent use of placeholders
- Natural Hungarian phrasing that maintains the informal tone
- Proper punctuation and formatting
ghost/i18n/locales/hu v2/comments.json (1)
70-70:⚠️ Potential issueFix typo in Hungarian word.
There's a typo in the Hungarian translation: "róbáld" should be "próbáld".
- "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, róbáld újra", + "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, próbáld újra",Likely invalid or redundant comment.
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
Hey @eszterik, thanks for these contributions!
Please review the comments by CodeRabbit - it's correct in flagging your errors in variable names. Those must be corrected.
Additionally, these files need to be submitted as edits to /locales/hu/.json, not as a separate directory.
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
Hey @eszterik, thanks for these contributions!
Please review the comments by CodeRabbit - it's correct in flagging your errors in variable names. Those must be corrected.
Additionally, these files need to be submitted as edits to /locales/hu/.json, not as a separate directory.
A few other comments as well based on my AI-based review. I'm not a Hungarian speaker, so feel free to override, but I've often found that many AI flags are worth considering.
ghost/i18n/locales/hu v2/ghost.json
Outdated
| "Thank you for signing up to {{siteTitle}}!": "{{siteTitle}} — Köszönjük a regisztrációt!", | ||
| "Thank you for subscribing to {{siteTitle}}!": "{{siteTitle}} — Köszönjük a feliratkozást!", | ||
| "Thank you for subscribing to {{siteTitle}}.": "{{siteTitle}} — Köszönjük a feliratkozást!", | ||
| "Thank you for subscribing to {{siteTitle}}. Tap the link below to be automatically signed in:": "Köszönjük a feliratkozást! Kérjük, kattints az alábbi linkre az automatikus bejelentkezéshez:", |
There was a problem hiding this comment.
You need to use the {{siteTitle}} variable in the translations.
"You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Ezt azért kapod, mert <strong>%%{status}%% feliratkoztál</strong> ide: {site}",
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| "View in browser": "Megnyitás a böngészőben", | ||
| "You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Ezt azért kapod, mert <strong>%%{status}%% subscriber</strong> to {site}", | ||
| "You are receiving this because you are a <strong>%%{status}%% subscriber</strong> to {site}.": "Ezt azért kapod, mert <strong>%%{status}%% előfizető</strong> vagy itt: {site}", | ||
| "Your free trial ends on {date}, at which time you will be charged the regular price. You can always cancel before then.": "Az ingyenes próbaidőszak után fiókod automatikusan átvált előfizetésesre. A próbaidőszak alatt bármikor lemondhatod az előfizetésedet.", |
There was a problem hiding this comment.
This problem remains, that the {date} section is missing.
|
Hi @eszterik , I am still seeing hu v2 for your directory name, when it should be hu. You're right that you need to copy the changes to the hu directory, and delete the hu v2 directory. Probably the best way to do that is to go into your copy of the repository (https://github.com/eszterik/Ghost/tree/main) and press . (the period key), then open folders on the left side. Right click on the hu folder and choose delete. Then right click on hu v2 and rename it to hu. Then commit your changes. That'll update the PR. You'll know you've done it right if you view the "files changed" section of the PR and see files in /hu/, with no sign of /hu v2/. |
|
I'm not going to review this further as I see that @peterzimon has self assigned, and he's far better qualified to review the translations than I am. (But you DO need to fix the folders.) |
@coderabbitai , this is a bad suggestion. The keys in these json files should not be changed by translators. The %%{status}%% placeholder is required for string replacement by Mailgun and is correct just as it is. Keys should not be changed if a PR is just making corrections/additions to translation files in ghost/i18n/locales |
|
@cathysarisky Thank you for the correction. I understand now that placeholders should not be modified in translation files, and that ✏️ Learnings added
✅ Actions performedComments resolved. |
|
Apologies to the humans for the extra comment spam. Trying to teach our AI bunny how to be its best self. 😆 |
@cathysarisky Is it okay? |
|
You won’t hurt Ghost. The very worst that could happen is that you lose your work (so make a copy first in your local computer). |
|
Okay, thanks! I did it. |
I'm not seeing it. It still shows up as changes in hu v2. Happy to review this and queue it up for merge, but this needs fixing first. 🙏 |
|
Hello @cathysarisky, I'm sorry, I am not sure what I should do at the moment. I followed your instructions, and it seemed okay. I attached a screenshot because I see only .hu folder. I really appreciate your support, thank you! |
|
See the icon with the blue 12 on the left side of your screen shot? Click it. You’re going to select your changes and commit them on the menu panel that appears. |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (6)
ghost/i18n/locales/hu/signup-form.json (1)
2-5: Inconsistent Tone in Signup Form Translations
Most of the updates adopt an informal tone (e.g. “Ellenőrizd az e-mailed” on line 3), but on line 4 the phrase
"Please enter a valid email address": "Kérjük, érvényes e-mail-címet adjál meg"
still uses the formal “Kérjük” along with “adjál meg”. For consistency with the overall informal style, consider revising this to something like:
"Please enter a valid email address": "Kérlek, érvényes e-mail-címet add meg"
This will help maintain a uniform, friendly tone across the interface.ghost/i18n/locales/hu/newsletter.json (1)
2-23: Overall Improvements in Newsletter Localization
The revisions provide meaningful translations and correctly preserve critical placeholders such as {{memberEmail}}, {{newsletterName}}, etc. Two points to consider:
- The term for "trialing" is now translated as "utólag" which may not fully capture the concept of a trial period. Revisiting this term (e.g. "próbaidőszak alatt") might improve clarity.
- Verify that "Member since" translated as "Tag vagy ekkortól" fully conveys the intended meaning.
Otherwise, the improvements are solid.ghost/i18n/locales/hu/ghost.json (2)
3-7: Adjusting Tone Consistency in Ghost Translations
The updated strings are largely shifted toward an informal, friendly tone (e.g. "Szia!" replacing formal greetings). However, on line 7 the text
"Confirm your email address": "Kérjük, erősítsd meg az e-mail-címed!"
still uses "Kérjük," which is more formal. Consider revising it to "Kérlek, erősítsd meg az e-mail-címed!" so that all instructions consistently reflect the informal voice.
2-33: Overall Informal Tone and Consistency Check
The extensive updates in this file reflect the PR objective of moving toward a more conversational style. Please double-check that all instances—especially those still using formal markers like "Kérjük"—are updated to a uniformly informal tone.ghost/i18n/locales/hu/comments.json (2)
6-15: Improved Informal Tone in Comments Translations
The updated translations now read much friendlier—for example, "{{amount}} more" becomes "{{amount}} még" and "Already a member?" now appears as "Van már fiókod?"
One note: the phrases for membership (lines 14–15) have been reworded to "Hozzászólást csak a tagok/előfizetők írhatnak." This effectively restricts commenting to members. Please verify that these changes reflect the intended access control behavior in the application.
36-39: Consistent Tone in Discussion Prompts
For the call-to-action "Join the discussion" (line 36), the current translation "Csatlakozás a beszélgetéshez" is clear. For an even more colloquial feel, consider using the imperative form such as "Csatlakozz a beszélgetéshez."
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
ghost/i18n/locales/hu/comments.json(1 hunks)ghost/i18n/locales/hu/ghost.json(1 hunks)ghost/i18n/locales/hu/newsletter.json(1 hunks)ghost/i18n/locales/hu/portal.json(2 hunks)ghost/i18n/locales/hu/search.json(1 hunks)ghost/i18n/locales/hu/signup-form.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- ghost/i18n/locales/hu/search.json
🧰 Additional context used
🧠 Learnings (1)
ghost/i18n/locales/hu/portal.json (2)
Learnt from: cathysarisky
PR: TryGhost/Ghost#21982
File: ghost/i18n/locales/hu v2/portal.json:206-208
Timestamp: 2025-01-22T15:52:28.151Z
Learning: In localization files, variable placeholders must exactly match their source strings (e.g., {{renewalDate}} in the translation must match {{renewalDate}} in the source) to ensure proper variable substitution and display.
Learnt from: cathysarisky
PR: TryGhost/Ghost#21982
File: ghost/i18n/locales/hu v2/portal.json:70-70
Timestamp: 2025-01-29T15:23:58.658Z
Learning: Typos and spelling errors within localization files (ghost/i18n/locales/*.json) must be treated as important problems, not nitpicks, as they directly affect the user experience for speakers of that language. These issues should be flagged with high priority during code review.
🔇 Additional comments (6)
ghost/i18n/locales/hu/signup-form.json (1)
7-8: Clear and Contextual Messaging
The instructions on completing signup (line 7) and the label for the email address (line 8) are clear and now reflect a more conversational style.ghost/i18n/locales/hu/ghost.json (2)
11-14: Streamlined Greetings and Action Prompts
The changes that turn "Hey there," and "Hey there!" into "Szia!" (lines 11–12) and the subsequent action prompts are concise and match the updated friendly tone.
24-25: Placeholder and Spacing Verification
Translations such as "Thank you for subscribing to {{siteTitle}}." and its extended variant preserve the original placeholders correctly. Also, note the use of a non-breaking space (encoded as “\u00a0” on line 3) to maintain formatting—please ensure that this renders as intended in all target environments.ghost/i18n/locales/hu/comments.json (2)
27-31: Contextual Accuracy for Professional Titles
The translations for professional titles (e.g. "Founder @ Acme Inc" → "A(z) @ Sirály Kft. alapítója" and "Head of Marketing at Acme, Inc" → "Marketingvezető — Sirály") are appropriately localized. Double-check that the company names and punctuation meet your branding guidelines.
64-69: Maintaining Clarity in Actionable Messages
Action messages like "Start the conversation," "Sort by," and "Upgrade now" are translated clearly and maintain the informal tone. No issues are noted here.ghost/i18n/locales/hu/portal.json (1)
206-210: Final Consistency Check for Portal Translations
After addressing the above critical issues, please perform a final review of the remaining translations to ensure that all placeholders, such as those for pricing, dates, and email addresses, remain unaltered and that the overall tone and terminology match the approved style guidelines.
| "(save {{highestYearlyDiscount}}%)": "(spórolj {{highestYearlyDiscount}}%)", | ||
| "{{amount}} days free": "{{amount}} napig ingyen", | ||
| "{{amount}} off": "{{amount}} kedvezmény", | ||
| "{{amount}} off for first {{number}} months.": "{{amount}} kedvezmény az első {{number}} hónapig.", | ||
| "{{amount}} off for first {{period}}.": "{{amount}} kedvezmény eddig: {{period}}", | ||
| "{{amount}} off forever.": "{{amount}} kedvezmény örökké", | ||
| "{{discount}}% discount": "{{discount}}% kedvezmény", | ||
| "{{memberEmail}} will no longer receive {{newsletterName}} newsletter.": "A(z) {{memberEmail}} cím már nem fogja megkapni a {{newsletterName}} hírlevelet", | ||
| "{{memberEmail}} will no longer receive emails when someone replies to your comments.": "A(z) {{memberEmail}} cím már nem fog kapni email-eket ha valaki válaszol a hozzászólásaira.", | ||
| "{{memberEmail}} will no longer receive this newsletter.": "A(z) {{memberEmail}} cím már nem fogja megkapni ezt a hírlevelet", | ||
| "{{memberEmail}} will no longer receive {{newsletterName}} newsletter.": "A(z) {{memberEmail}} cím többé nem kap {{newsletterName}} hírlevelet", | ||
| "{{memberEmail}} will no longer receive emails when someone replies to your comments.": "A(z) {{memberEmail}} többé nem kap e-mailt, ha valaki válaszol a hozzászólásaira.", | ||
| "{{memberEmail}} will no longer receive this newsletter.": "A(z) {{memberEmail}} cím többé nem kapja meg ezt a hírlevelet", | ||
| "{{trialDays}} days free": "{{trialDays}} nap ingyen", | ||
| "+1 (123) 456-7890": "", | ||
| "A login link has been sent to your inbox. If it doesn't arrive in 3 minutes, be sure to check your spam folder.": "A bejelentkezéshez szükséges linket elküldtük a megadott email címre. Ha nem érkezne meg 3 percen belül, kérjük ellenőrizze a spam mappát!", | ||
| "+1 (123) 456-7890": "+1 (123) 456-7890", | ||
| "A login link has been sent to your inbox. If it doesn't arrive in 3 minutes, be sure to check your spam folder.": "A bejelentkezéshez szükséges linket elküldtük a megadott e-mail-címre. Ha nem érkezik meg 3 percen belül, ellenőrizd a spam mappát!", | ||
| "Account": "Fiók", | ||
| "Account details updated successfully": "", | ||
| "Account details updated successfully": "A fiók adatai sikeresen frissítve.", | ||
| "Account settings": "Fiók beállítások", | ||
| "After a free trial ends, you will be charged the regular price for the tier you've chosen. You can always cancel before then.": "Az ingyenes próbaidőszak lejárta után a kiválasztott csomag normál díját fogjuk felszámolni. A feliratkozás bármikor ingyenesen lemondható a próbaidőszak alatt.", | ||
| "Already a member?": "Már van fiókja?", | ||
| "An error occurred": "", | ||
| "An unexpected error occured. Please try again or <a>contact support</a> if the error persists.": "Egy nem várt hiba történt! Kérjük próbálkozzon újra vagy <a>lépjen kapcsolatba velünk</a> ha a hiba továbbra is fennál.", | ||
| "After a free trial ends, you will be charged the regular price for the tier you've chosen. You can always cancel before then.": "Az ingyenes próbaidőszak lejárta után a kiválasztott csomag normál díját fogjuk felszámolni. A próbaidőszak alatt bármikor lemondhatod az előfizetésedet.", | ||
| "Already a member?": "Már tag vagy?", | ||
| "An error occurred": "Hiba történt.", | ||
| "An unexpected error occured. Please try again or <a>contact support</a> if the error persists.": "Egy nem várt hiba történt! Kérjük, próbáld meg újra, vagy <a>lépj kapcsolatba velünk</a>, ha a hiba fennmarad.", | ||
| "Back": "Vissza", | ||
| "Back to Log in": "Vissza a bejelentkezéshez", | ||
| "Billing info": "Számlázási információ", | ||
| "Black Friday": "Black Friday", | ||
| "Cancel anytime.": "Bármikor lemondható.", | ||
| "Cancel subscription": "Feliratkozás megszűntetése", | ||
| "Cancellation reason": "A megszűntetés oka", | ||
| "Change": "Változtat", | ||
| "Change plan": "", | ||
| "Check spam & promotions folders": "Kérjük ellenőrizze a spam és promóciók mappát", | ||
| "Check with your mail provider": "Lépjen kapcsolatba az email szolgáltatójával", | ||
| "Check your inbox to verify email update": "", | ||
| "Cancel subscription": "Előfizetés lemondása", | ||
| "Cancellation reason": "Az előfizetés lemondásának oka", | ||
| "Change": "Csere", | ||
| "Change plan": "Csomag cseréje", | ||
| "Check spam & promotions folders": "Kérjük, ellenőrizd a spam és a promóciók mappákat", | ||
| "Check with your mail provider": "Lépj kapcsolatba az e-mail szolgáltatóddal", | ||
| "Check your inbox to verify email update": "Kérjük, ellenőrizd az e-mailed az e-mail frissítés igazolásához", | ||
| "Choose": "Kiválaszt", | ||
| "Choose a different plan": "Válasszon másik csomagot", | ||
| "Choose a plan": "", | ||
| "Choose your newsletters": "Válassza ki a hírleveleket", | ||
| "Click here to retry": "Kattintson ide az újpróbáláshoz", | ||
| "Choose a different plan": "Válassz egy másik csomagot", | ||
| "Choose a plan": "Válassz egy csomagot", | ||
| "Choose your newsletters": "Válaszd ki a hírleveleidet", | ||
| "Click here to retry": "Kattints ide az újrapróbálkozáshoz", | ||
| "Close": "Bezár", | ||
| "Comments": "Hozzászólások", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Overall Consistency and Clarity in Portal Translations
The file shows extensive updates that align the language with a friendlier, informal tone. Most messages are clear and well-localized. Please review all error and action messages for accuracy, ensuring that each message’s context (e.g. billing, plan changes, notifications) is conveyed correctly.
ghost/i18n/locales/hu/portal.json
Outdated
| "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, próbáld újra", | ||
| "Failed to process checkout, please try again": "Nem sikerült bejelentkezni. Kérjük, próbáld újra", |
There was a problem hiding this comment.
Critical: Incorrect Message for Checkout Failure
The error message for "Failed to process checkout, please try again" currently translates to:
"Nem sikerült bejelentkezni. Kérjük, próbáld újra"
which erroneously refers to a login failure (bejelentkezni) rather than a checkout/payment process.
Please update it to accurately reflect the checkout context. For example:
-"Failed to process checkout, please try again": "Nem sikerült bejelentkezni. Kérjük, próbáld újra",
+"Failed to process checkout, please try again": "Nem sikerült feldolgozni a fizetést. Kérjük, próbáld újra",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, próbáld újra", | |
| "Failed to process checkout, please try again": "Nem sikerült bejelentkezni. Kérjük, próbáld újra", | |
| "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, próbáld újra", | |
| "Failed to process checkout, please try again": "Nem sikerült feldolgozni a fizetést. Kérjük, próbáld újra", |
There was a problem hiding this comment.
This is the message that will display if something goes wrong with setting up for the user to pay for a plan. Coderabbit seems to think you've got an error here, so please double check it. :)
There was a problem hiding this comment.
@cathysarisky Yes, you're right! The current translation incorrectly refers to a login failure ("bejelentkezni" means "to log in") instead of a checkout/payment process failure. The translation should be updated to:
"Failed to process checkout, please try again": "Nem sikerült feldolgozni a fizetést. Kérjük, próbáld újra"
This accurately conveys that there was an issue with processing the payment, which is what users should see if something goes wrong during the checkout process.
✏️ Learnings added
Learnt from: cathysarisky
PR: TryGhost/Ghost#21982
File: ghost/i18n/locales/hu/portal.json:70-71
Timestamp: 2025-02-15T16:00:03.710Z
Learning: In Hungarian translations for Ghost, payment/checkout related error messages should use "fizetés" (payment) related terms, not "bejelentkezés" (login) related terms, to accurately reflect the context of payment processing.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
| "Your account": "Fiókod", | ||
| "Your email has failed to resubscribe, please try again": "Az e-mail-címedet nem sikerült újra regisztrálni. Kérjük, próbáld újra", | ||
| "Your input helps shape what gets published.": "A visszajelzésed segít abban, hogy miről írjunk", |
There was a problem hiding this comment.
Critical: Incorrect Variable Placeholders in Subscription Dates
The translations for the subscription dates use incorrect placeholders. Currently:
"Your subscription will renew on {{renewalDate}}": "Az előfizetésed megújul ekkor: {{expiryDate}}"
"Your subscription will start on {{subscriptionStart}}": "Az előfizetésed ekkor indul: {{expiryDate}}"
This will cause mis-substitution in the UI. They should instead use the original variables. Please update as follows:
-"Your subscription will renew on {{renewalDate}}": "Az előfizetésed megújul ekkor: {{expiryDate}}",
+"Your subscription will renew on {{renewalDate}}": "Az előfizetésed megújul ekkor: {{renewalDate}}",
-"Your subscription will start on {{subscriptionStart}}": "Az előfizetésed ekkor indul: {{expiryDate}}"
+"Your subscription will start on {{subscriptionStart}}": "Az előfizetésed ekkor indul: {{subscriptionStart}}"Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
cathysarisky
left a comment
cathysarisky
left a comment
There was a problem hiding this comment.
You fixed the folder issue, hooray! :)
There are a couple comments from coderabbit that merit your review, and I'll also take a look over it on Monday. (Feel free to fix the coderabbit-identified issues now -- no need to wait for me..)
ghost/i18n/locales/hu/portal.json
Outdated
| "Failed to log out, please try again": "Nem sikerült kijelentkezni. Kérjük, próbáld újra", | ||
| "Failed to process checkout, please try again": "Nem sikerült bejelentkezni. Kérjük, próbáld újra", |
There was a problem hiding this comment.
This is the message that will display if something goes wrong with setting up for the user to pay for a plan. Coderabbit seems to think you've got an error here, so please double check it. :)
ghost/i18n/locales/hu/portal.json
Outdated
| "Your email has failed to resubscribe, please try again": "Az e-mail-címedet nem sikerült újra regisztrálni. Kérjük, próbáld újra", | ||
| "Your input helps shape what gets published.": "A visszajelzésed segít abban, hogy miről írjunk", | ||
| "Your subscription will expire on {{expiryDate}}": "Az előfizetésed lejár ekkor: {{expiryDate}}", | ||
| "Your subscription will renew on {{renewalDate}}": "Az előfizetésed megújul ekkor: {{expiryDate}}", |
There was a problem hiding this comment.
@eszterik Please have a look at lines 207-208, where the variable name was changed.
@coderabbitai - nice job identifying this problem!
There was a problem hiding this comment.
@cathysarisky Thank you for the feedback! Yes, it's important to maintain consistency with variable placeholders in translations.
✏️ Learnings added
Learnt from: cathysarisky
PR: TryGhost/Ghost#21982
File: ghost/i18n/locales/hu/portal.json:207-207
Timestamp: 2025-02-15T16:00:03.213Z
Learning: In Hungarian translations for Ghost, ensure that all variables like {{title}} are preserved in the translated strings and not omitted.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
There was a problem hiding this comment.
Hello @cathysarisky I fixed these two mistakes. I hope you see them.
I have a question: what is the difference between these two lines (in the meaning): "Failed to update account data": "",
"Failed to update account details":
(You can see in the portal.json lines 91-92. My translation is the same. Thank you!
There was a problem hiding this comment.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
There was a problem hiding this comment.
Hello @cathysarisky, I also checked the nitpick comments and fixed them where Rabbit was right:)
Kérlek - Kérjük - I ask you - We ask you (Please). Kérjük is not formal in this context, it is also used in informal way (actually, no other options).
|
There are some potentially-useful comments from coderabbit about tone, hidden within "nitpick" comments - have a look and see if it is right about anything, please. (It may not be - I'm sure you speak better Hungarian than it does.) |
|
Looks like you maybe forgot to actually commit your changes? Back to the "merge" icon, which probably has a blue badge, and get those changes committed, please! :) |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ghost/i18n/locales/hu/comments.json (2)
14-15: Adjustment of Membership Prompts
The original calls-to-action have been shifted from prompting users to join (i.e. “Become a member…” / “Become a paid member…”) to stating that only members or subscribers can comment. The new texts—"Hozzászólást csak tagok írhatnak."and"Hozzászólást csak előfizetők írhatnak."—reflect this change. Please verify that this change in messaging is intentional based on the design specifications.
29-29: Localization Update for "Founder @ Acme Inc"
The translation has been updated to"A(z) @ Sirály Kft. alapítója", replacing"Acme Inc"with"Sirály Kft.". Ensure that this change is in line with current branding and localization requirements.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
ghost/i18n/locales/hu/comments.json(1 hunks)ghost/i18n/locales/hu/newsletter.json(1 hunks)ghost/i18n/locales/hu/portal.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- ghost/i18n/locales/hu/newsletter.json
- ghost/i18n/locales/hu/portal.json
🔇 Additional comments (21)
ghost/i18n/locales/hu/comments.json (21)
6-6: Translation Accuracy for "{{amount}} more"
The updated translation"{{amount}} még"maintains the correct placeholder and provides a clear, concise Hungarian equivalent.
9-9: Informal Tone for "Add context to your comment"
The new translation"Segítsd a beszélgetést azzal, hogy megadod a nevedet és azt, hogy mihez értesz."adopts a friendly and direct tone that aligns with the informal style desired.
11-11: Informal Approach for "Already a member?"
Changing the formal"Már van fiókja?"to the informal"Van már fiókod?"effectively matches the modern, friendly tone.
13-13: Casual Confirmation Update
The phrase"Are you sure?"is now rendered as"Biztos vagy benne?"which is both clear and suitably informal.
20-20: Completion of "Deleted" Translation
Providing"Törölt"for the"Deleted"state fills the previous gap and ensures a complete localization.
22-22: Translation for "Deleting" State
The update to"Törölni"correctly reflects the ongoing action, keeping the tone consistent with the rest of the translations.
27-27: Informal Prompt for Name Entry
Changing"Enter your name"to"Add meg a nevedet"effectively adopts an informal style that matches the overall PR objective.
31-31: Consistent Localization for "Head of Marketing"
Updating this key to"Marketingvezető — Sirály Kft."is consistent with the change made on line 29. Please confirm that this alteration fits the overall localization strategy.
32-32: Addition for "Hidden for members"
The added translation"A tagok számára elrejtve"fills a missing piece, ensuring that all user roles are clearly communicated.
36-36: Updated Call-to-Action for Joining
The translation"Csatlakozz a beszélgetéshez"for"Join the discussion"is engaging and clear, encouraging users to take part in the conversation.
39-39: Refinement of "Member discussion"
Changing to"Tagok beszélgetése"offers a natural and succinct phrasing.
42-42: Clarification on Irreversible Deletion
The warning"Once deleted, this comment can’t be recovered."is now clearly expressed as"A törlés után ez a hozzászólás nem állítható vissza.", which accurately informs users of the irreversible action.
45-45: Accurate Translation for "Replied to"
The update to"Válaszolt erre"captures the intended meaning precisely.
47-48: Consistency in Reply Prompts
The translations for"Reply to"as"Válasz"and"Reply to comment"as"Válasz a hozzászólásra"are consistent. It might be worthwhile to double-check that using the same term for"Reply"in different contexts does not create any ambiguity in the UI.
56-56: Clear Translation for Reply Count
The phrase"Show {{amount}} more replies"is now"Mutass {{amount}} további választ", which correctly preserves the variable placeholder and offers clear instruction.
59-59: Concise Update for Previous Comment Prompt
The change to"Mutass egy előző hozzászólást"is succinct and clear. Consider if using an alternative adjective like"korábbi"might enhance the natural flow, though the current version is acceptable.
62-62: Invitation for Registration in Informal Tone
Translating"Sign up now"to"Regisztrálj most"successfully aligns with the informal, contemporary tone of the PR.
63-63: Simplified Sorting Control
The expression"Sort by"has been translated as"Rendezés", which is concise and easy to understand.
64-64: Engaging Conversation Starter
Converting"Start the conversation"to"Kezdd el a beszélgetést"offers an inviting prompt that fits well with modern, informal wording.
67-67: Verification of Upgrade Call-to-Action
The phrase"Upgrade now"is rendered as"Fizess elő most", which implies a subscription action. Please verify that this translation accurately reflects the intended user flow for upgrading.
69-69: User Notification Update
The updated translation"A kérésedet továbbítjuk a weboldal tulajdonosának."clearly conveys the message in a friendly and accessible manner.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/hu/comments.json (1)
14-15: Membership prompts update & placeholder omission.
The original English strings contained the dynamic{{publication}}token, but the new translations—
• "Become a member of {{publication}} to start commenting." → "Hozzászólást csak tagok írhatnak."
• "Become a paid member of {{publication}} to start commenting." → "Hozzászólást csak előfizetők írhatnak."
omit this placeholder. Please verify that the removal of{{publication}}is intentional and does not disrupt the intended display of dynamic publication names in the UI.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ghost/i18n/locales/hu/comments.json(1 hunks)
🔇 Additional comments (24)
ghost/i18n/locales/hu/comments.json (24)
6-6: Update to the dynamic placeholder for "more".
The new translation preserves the{{amount}}placeholder correctly and reads naturally in Hungarian.
9-9: Refined guidance on providing context.
The updated translation for the help text on adding context is clear and adopts the desired informal tone.
11-11: Informal tone for membership prompt.
Changing "Already a member?" to "Van már fiókod?" successfully shifts from the formal to the informal tone as intended.
13-13: Casual phrasing for confirmation prompt.
The translation for "Are you sure?" as "Biztos vagy benne?" is natural and matches the overall informal style.
20-20: Addition of "Deleted" translation.
Providing a translation for "Deleted" as "Törölt" fills a previous gap and is clear.
22-22: Addition of "Deleting" translation.
The new entry "Törölni" effectively communicates the ongoing action.
27-27: Informal rewording for "Enter your name".
Switching from the formal "Adja meg a nevét" to "Add meg a nevedet" appropriately matches the intended friendly tone.
29-29: Localized company reference for "Founder @ Acme Inc".
Replacing "Acme Inc" with "Sirály Kft." in "A(z) @ Sirály Kft. alapítója" adapts the string for the Hungarian context effectively.
31-31: Localized professional title update.
The translation for "Head of Marketing at Acme, Inc" now reads "Marketingvezető — Sirály Kft." which is correctly localized and fits the targeted informal style.
32-32: Translation for "Hidden for members".
The new string "A tagok számára elrejtve" clearly communicates the intended meaning.
36-36: Updated call-to-action for joining the discussion.
The translation "Csatlakozz a beszélgetéshez" is concise and fits the overall informal tone.
39-39: Translation for "Member discussion".
Changing this to "Tagok beszélgetése" maintains consistency and clarity.
42-42: Enhanced clarity on comment deletion warning.
The updated translation "A törlés után ez a hozzászólás nem állítható vissza." is unambiguous and reader‐friendly.
45-45: Translation update for "Replied to".
The new version "Válaszolt erre" is concise and fits naturally within a conversational interface.
47-47: Concise revision for "Reply to".
The translation "Válasz" offers a succinct alternative that still conveys the intended action.
48-48: Clear instruction for replying.
"Reply to comment" translated as "Válasz a hozzászólásra" is easily understood and aligns with the overall tone.
51-51: Interrogative rewording for reporting a comment.
The updated "Report this comment?" → "Szeretnéd jelenteni ezt a hozzászólást?" invites the user naturally to take action.
56-56: Accurate inclusion of dynamic content in replies.
The string "Show {{amount}} more replies" now correctly integrates the{{amount}}placeholder within "Mutass {{amount}} még válaszokat".
59-59: Updated translation for viewing previous comments.
"Show 1 previous comment" rendered as "Mutass egy előző hozzászólást" is clear and direct.
62-62: Effective call-to-action for registration.
The change to "Regisztrálj most" for "Sign up now" fits the informal and engaging style targeted by the PR.
63-63: Clear and straightforward translation for "Sort by".
The updated version "Rendezés" is accurate and easily understandable.
64-64: Warm invitation to initiate conversation.
"Start the conversation" becomes "Kezdd el a beszélgetést", which is inviting and on-brand.
67-67: Reworked upgrade prompt.
The new translation "Előfizetéssel te is hozzászólhatsz" shifts focus toward the benefit of upgrading. Please verify that this phrasing aligns with the product’s messaging strategy and that it does not overly dilute the original "Upgrade now" call-to-action.
69-69: Streamlined communication for support requests.
The updated "Your request will be sent to the owner of this site." → "A kérésedet továbbítjuk a weboldal tulajdonosának." is direct and user-friendly.
|
@cathysarisky Hello Cathy, do you have any updates on these changes? When will the updates go live on the websites? Thank you, Eszter |
Let me follow up on that. I thought I'd put it on the list for merging, but either I missed it, or the member of the Ghost core team doing the merging missed it. Will get it queued! Update: Nope, we're waiting on a review from Zimo, who says he'll get to it tomorrow. Sorry for the delay! |
ghost/i18n/locales/hu/comments.json
Outdated
| "Sent": "Elküldve", | ||
| "Show": "Mutat", | ||
| "Show {{amount}} more replies": "Mutass még {{amount}} választ", | ||
| "Show {{amount}} more replies": "Mutass {{amount}} még válaszokat", |
There was a problem hiding this comment.
Hey @eszterik!!
Amazing work, thank you so much, it really sounds much better in Hungarian. The only one I found that I'd go back to the original translation is this one: {{amount}} is a number and so e.g. for 5 more replies the original is "Mutass még 5 választ" which sounds better than "Mutass 5 még válaszokat"
Otherwise all looks great, thanks again!
(I'm also from Hungary :) )
There was a problem hiding this comment.
Hello @peterzimon!
Thank you for checking it! I'm glad that another Hungarian speaker thinks it works. :) I’ll change the sentence you mentioned - you’re right, this sounds better. :) Best, Eszter
There was a problem hiding this comment.
Hello @cathysarisky,
I corrected what Peter mentioned. Thank you for reaching out to him!
And thank you again for your patience and careful work—I know I was sometimes (or maybe more than sometimes!:) a bit clueless. But at least I finally learned more or less how GitHub works! :)
Best,
Eszter
There was a problem hiding this comment.
Hi @eszterik,
Can you take care of resolving the conflicts in the json files so we're able to merge your changes?
Thank you
There was a problem hiding this comment.
Hi @eszterik - I'm guessing you're going to need some directions on how to do that ^^ ?
Here are directions!
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github
There was a problem hiding this comment.
Hello @cathysarisky, I'm sorry, but it is still not clear where and how should I do this things...Could you help me? Thanks!
There was a problem hiding this comment.
Great, thank you for your reply @cathysarisky. Does this mean I don't have anything more to do?
|
Hi! Do you have any idea when these changes can be seen? I tried to refresh, but all I see is still the old Hungarian version |
|
The changes are live in Portal 2.50, with Ghost 5.113. If you're self hosting, please update Ghost. If you're on Ghost Pro and aren't seeing the changes, you may need to wait one more day. Typically Ghost Pro lags the release by a couple of business days, so I'd expect most Ghost Pro sites to get the update by today. |
6 participants
Hello! I've rewritten the Hungarian locale because I found the current version quite problematic. As a native Hungarian speaker, I noticed that some texts are missing, while others contain misspellings and sound overly robotic. Native Hungarian speakers don't typically use the expressions or sentence structures present in the original version.
Additionally, I changed the polite second formal pronouns to an informal and friendly tone. (In Hungarian, this is similar to the distinction between the formal and informal "Sie/sie" in German.) For newsletters and new media formats, we generally don't use the formal style; it comes across as somewhat outdated and doesn't align with the Ghost.org style either.
I hope you like my new version.
As for my qualifications, I am a native Hungarian speaker, journalist, and copywriter. I am open to discussing my changes further. All the best, and I look forward to hearing from you!