feat: add fr-fr locale by goldyfruit · Pull Request #45 · OpenVoiceOS/ovos-skill-days-in-history

goldyfruit · 2026-03-17T01:13:04Z

Summary

add a complete fr-fr locale for the skill
translate the assistant-facing intents, follow-up vocab, dialogs, and skill.json
add the French history corpus for births, deaths, and events across the full calendar
add translations/fr-fr/intents.json and translations/fr-fr/vocabs.json

Notes

year markers were preserved so pronounce_year() keeps working correctly
the French wrapper dialogs and examples were written for spoken assistant usage
I cleaned a few obvious generated title artifacts in the history corpus, especially papal titles and grand-prince

Validation

fr-fr file coverage matches en-us (1107 files)
python -m json.tool locale/fr-fr/skill.json
python -m json.tool translations/fr-fr/intents.json
python -m json.tool translations/fr-fr/vocabs.json
git diff --check

coderabbitai · 2026-03-17T01:13:12Z

Important

Review skipped

Too many files!

This PR contains 300 files, which is 150 over the limit of 150.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 224d0771-c133-4c3b-ac27-a1c1be5263bc

📥 Commits

Reviewing files that changed from the base of the PR and between 699fbb9 and f21eb4c.

📒 Files selected for processing (300)

locale/fr-fr/TellMeMore.voc
locale/fr-fr/births_in_history.intent
locale/fr-fr/day_10_month_10_births.dialog
locale/fr-fr/day_10_month_10_deaths.dialog
locale/fr-fr/day_10_month_10_events.dialog
locale/fr-fr/day_10_month_11_births.dialog
locale/fr-fr/day_10_month_11_deaths.dialog
locale/fr-fr/day_10_month_11_events.dialog
locale/fr-fr/day_10_month_12_births.dialog
locale/fr-fr/day_10_month_12_deaths.dialog
locale/fr-fr/day_10_month_12_events.dialog
locale/fr-fr/day_10_month_1_births.dialog
locale/fr-fr/day_10_month_1_deaths.dialog
locale/fr-fr/day_10_month_1_events.dialog
locale/fr-fr/day_10_month_2_births.dialog
locale/fr-fr/day_10_month_2_deaths.dialog
locale/fr-fr/day_10_month_2_events.dialog
locale/fr-fr/day_10_month_3_births.dialog
locale/fr-fr/day_10_month_3_deaths.dialog
locale/fr-fr/day_10_month_3_events.dialog
locale/fr-fr/day_10_month_4_births.dialog
locale/fr-fr/day_10_month_4_deaths.dialog
locale/fr-fr/day_10_month_4_events.dialog
locale/fr-fr/day_10_month_5_births.dialog
locale/fr-fr/day_10_month_5_deaths.dialog
locale/fr-fr/day_10_month_5_events.dialog
locale/fr-fr/day_10_month_6_births.dialog
locale/fr-fr/day_10_month_6_deaths.dialog
locale/fr-fr/day_10_month_6_events.dialog
locale/fr-fr/day_10_month_7_births.dialog
locale/fr-fr/day_10_month_7_deaths.dialog
locale/fr-fr/day_10_month_7_events.dialog
locale/fr-fr/day_10_month_8_births.dialog
locale/fr-fr/day_10_month_8_deaths.dialog
locale/fr-fr/day_10_month_8_events.dialog
locale/fr-fr/day_10_month_9_births.dialog
locale/fr-fr/day_10_month_9_deaths.dialog
locale/fr-fr/day_10_month_9_events.dialog
locale/fr-fr/day_11_month_10_births.dialog
locale/fr-fr/day_11_month_10_deaths.dialog
locale/fr-fr/day_11_month_10_events.dialog
locale/fr-fr/day_11_month_11_births.dialog
locale/fr-fr/day_11_month_11_deaths.dialog
locale/fr-fr/day_11_month_11_events.dialog
locale/fr-fr/day_11_month_12_births.dialog
locale/fr-fr/day_11_month_12_deaths.dialog
locale/fr-fr/day_11_month_12_events.dialog
locale/fr-fr/day_11_month_1_births.dialog
locale/fr-fr/day_11_month_1_deaths.dialog
locale/fr-fr/day_11_month_1_events.dialog
locale/fr-fr/day_11_month_2_births.dialog
locale/fr-fr/day_11_month_2_deaths.dialog
locale/fr-fr/day_11_month_2_events.dialog
locale/fr-fr/day_11_month_3_births.dialog
locale/fr-fr/day_11_month_3_deaths.dialog
locale/fr-fr/day_11_month_3_events.dialog
locale/fr-fr/day_11_month_4_births.dialog
locale/fr-fr/day_11_month_4_deaths.dialog
locale/fr-fr/day_11_month_4_events.dialog
locale/fr-fr/day_11_month_5_births.dialog
locale/fr-fr/day_11_month_5_deaths.dialog
locale/fr-fr/day_11_month_5_events.dialog
locale/fr-fr/day_11_month_6_births.dialog
locale/fr-fr/day_11_month_6_deaths.dialog
locale/fr-fr/day_11_month_6_events.dialog
locale/fr-fr/day_11_month_7_births.dialog
locale/fr-fr/day_11_month_7_deaths.dialog
locale/fr-fr/day_11_month_7_events.dialog
locale/fr-fr/day_11_month_8_births.dialog
locale/fr-fr/day_11_month_8_deaths.dialog
locale/fr-fr/day_11_month_8_events.dialog
locale/fr-fr/day_11_month_9_births.dialog
locale/fr-fr/day_11_month_9_deaths.dialog
locale/fr-fr/day_11_month_9_events.dialog
locale/fr-fr/day_12_month_10_births.dialog
locale/fr-fr/day_12_month_10_deaths.dialog
locale/fr-fr/day_12_month_10_events.dialog
locale/fr-fr/day_12_month_11_births.dialog
locale/fr-fr/day_12_month_11_deaths.dialog
locale/fr-fr/day_12_month_11_events.dialog
locale/fr-fr/day_12_month_12_births.dialog
locale/fr-fr/day_12_month_12_deaths.dialog
locale/fr-fr/day_12_month_12_events.dialog
locale/fr-fr/day_12_month_1_births.dialog
locale/fr-fr/day_12_month_1_deaths.dialog
locale/fr-fr/day_12_month_1_events.dialog
locale/fr-fr/day_12_month_2_births.dialog
locale/fr-fr/day_12_month_2_deaths.dialog
locale/fr-fr/day_12_month_2_events.dialog
locale/fr-fr/day_12_month_3_births.dialog
locale/fr-fr/day_12_month_3_deaths.dialog
locale/fr-fr/day_12_month_3_events.dialog
locale/fr-fr/day_12_month_4_births.dialog
locale/fr-fr/day_12_month_4_deaths.dialog
locale/fr-fr/day_12_month_4_events.dialog
locale/fr-fr/day_12_month_5_births.dialog
locale/fr-fr/day_12_month_5_deaths.dialog
locale/fr-fr/day_12_month_5_events.dialog
locale/fr-fr/day_12_month_6_births.dialog
locale/fr-fr/day_12_month_6_deaths.dialog
locale/fr-fr/day_12_month_6_events.dialog
locale/fr-fr/day_12_month_7_births.dialog
locale/fr-fr/day_12_month_7_deaths.dialog
locale/fr-fr/day_12_month_7_events.dialog
locale/fr-fr/day_12_month_8_births.dialog
locale/fr-fr/day_12_month_8_deaths.dialog
locale/fr-fr/day_12_month_8_events.dialog
locale/fr-fr/day_12_month_9_births.dialog
locale/fr-fr/day_12_month_9_deaths.dialog
locale/fr-fr/day_12_month_9_events.dialog
locale/fr-fr/day_13_month_10_births.dialog
locale/fr-fr/day_13_month_10_deaths.dialog
locale/fr-fr/day_13_month_10_events.dialog
locale/fr-fr/day_13_month_11_births.dialog
locale/fr-fr/day_13_month_11_deaths.dialog
locale/fr-fr/day_13_month_11_events.dialog
locale/fr-fr/day_13_month_12_births.dialog
locale/fr-fr/day_13_month_12_deaths.dialog
locale/fr-fr/day_13_month_12_events.dialog
locale/fr-fr/day_13_month_1_births.dialog
locale/fr-fr/day_13_month_1_deaths.dialog
locale/fr-fr/day_13_month_1_events.dialog
locale/fr-fr/day_13_month_2_births.dialog
locale/fr-fr/day_13_month_2_deaths.dialog
locale/fr-fr/day_13_month_2_events.dialog
locale/fr-fr/day_13_month_3_births.dialog
locale/fr-fr/day_13_month_3_deaths.dialog
locale/fr-fr/day_13_month_3_events.dialog
locale/fr-fr/day_13_month_4_births.dialog
locale/fr-fr/day_13_month_4_deaths.dialog
locale/fr-fr/day_13_month_4_events.dialog
locale/fr-fr/day_13_month_5_births.dialog
locale/fr-fr/day_13_month_5_deaths.dialog
locale/fr-fr/day_13_month_5_events.dialog
locale/fr-fr/day_13_month_6_births.dialog
locale/fr-fr/day_13_month_6_deaths.dialog
locale/fr-fr/day_13_month_6_events.dialog
locale/fr-fr/day_13_month_7_births.dialog
locale/fr-fr/day_13_month_7_deaths.dialog
locale/fr-fr/day_13_month_7_events.dialog
locale/fr-fr/day_13_month_8_births.dialog
locale/fr-fr/day_13_month_8_deaths.dialog
locale/fr-fr/day_13_month_8_events.dialog
locale/fr-fr/day_13_month_9_births.dialog
locale/fr-fr/day_13_month_9_deaths.dialog
locale/fr-fr/day_13_month_9_events.dialog
locale/fr-fr/day_14_month_10_births.dialog
locale/fr-fr/day_14_month_10_deaths.dialog
locale/fr-fr/day_14_month_10_events.dialog
locale/fr-fr/day_14_month_11_births.dialog
locale/fr-fr/day_14_month_11_deaths.dialog
locale/fr-fr/day_14_month_11_events.dialog
locale/fr-fr/day_14_month_12_births.dialog
locale/fr-fr/day_14_month_12_deaths.dialog
locale/fr-fr/day_14_month_12_events.dialog
locale/fr-fr/day_14_month_1_births.dialog
locale/fr-fr/day_14_month_1_deaths.dialog
locale/fr-fr/day_14_month_1_events.dialog
locale/fr-fr/day_14_month_2_births.dialog
locale/fr-fr/day_14_month_2_deaths.dialog
locale/fr-fr/day_14_month_2_events.dialog
locale/fr-fr/day_14_month_3_births.dialog
locale/fr-fr/day_14_month_3_deaths.dialog
locale/fr-fr/day_14_month_3_events.dialog
locale/fr-fr/day_14_month_4_births.dialog
locale/fr-fr/day_14_month_4_deaths.dialog
locale/fr-fr/day_14_month_4_events.dialog
locale/fr-fr/day_14_month_5_births.dialog
locale/fr-fr/day_14_month_5_deaths.dialog
locale/fr-fr/day_14_month_5_events.dialog
locale/fr-fr/day_14_month_6_births.dialog
locale/fr-fr/day_14_month_6_deaths.dialog
locale/fr-fr/day_14_month_6_events.dialog
locale/fr-fr/day_14_month_7_births.dialog
locale/fr-fr/day_14_month_7_deaths.dialog
locale/fr-fr/day_14_month_7_events.dialog
locale/fr-fr/day_14_month_8_births.dialog
locale/fr-fr/day_14_month_8_deaths.dialog
locale/fr-fr/day_14_month_8_events.dialog
locale/fr-fr/day_14_month_9_births.dialog
locale/fr-fr/day_14_month_9_deaths.dialog
locale/fr-fr/day_14_month_9_events.dialog
locale/fr-fr/day_15_month_10_births.dialog
locale/fr-fr/day_15_month_10_deaths.dialog
locale/fr-fr/day_15_month_10_events.dialog
locale/fr-fr/day_15_month_11_births.dialog
locale/fr-fr/day_15_month_11_deaths.dialog
locale/fr-fr/day_15_month_11_events.dialog
locale/fr-fr/day_15_month_12_births.dialog
locale/fr-fr/day_15_month_12_deaths.dialog
locale/fr-fr/day_15_month_12_events.dialog
locale/fr-fr/day_15_month_1_births.dialog
locale/fr-fr/day_15_month_1_deaths.dialog
locale/fr-fr/day_15_month_1_events.dialog
locale/fr-fr/day_15_month_2_births.dialog
locale/fr-fr/day_15_month_2_deaths.dialog
locale/fr-fr/day_15_month_2_events.dialog
locale/fr-fr/day_15_month_3_births.dialog
locale/fr-fr/day_15_month_3_deaths.dialog
locale/fr-fr/day_15_month_3_events.dialog
locale/fr-fr/day_15_month_4_births.dialog
locale/fr-fr/day_15_month_4_deaths.dialog
locale/fr-fr/day_15_month_4_events.dialog
locale/fr-fr/day_15_month_5_births.dialog
locale/fr-fr/day_15_month_5_deaths.dialog
locale/fr-fr/day_15_month_5_events.dialog
locale/fr-fr/day_15_month_6_births.dialog
locale/fr-fr/day_15_month_6_deaths.dialog
locale/fr-fr/day_15_month_6_events.dialog
locale/fr-fr/day_15_month_7_births.dialog
locale/fr-fr/day_15_month_7_deaths.dialog
locale/fr-fr/day_15_month_7_events.dialog
locale/fr-fr/day_15_month_8_births.dialog
locale/fr-fr/day_15_month_8_deaths.dialog
locale/fr-fr/day_15_month_8_events.dialog
locale/fr-fr/day_15_month_9_births.dialog
locale/fr-fr/day_15_month_9_deaths.dialog
locale/fr-fr/day_15_month_9_events.dialog
locale/fr-fr/day_16_month_10_births.dialog
locale/fr-fr/day_16_month_10_deaths.dialog
locale/fr-fr/day_16_month_10_events.dialog
locale/fr-fr/day_16_month_11_births.dialog
locale/fr-fr/day_16_month_11_deaths.dialog
locale/fr-fr/day_16_month_11_events.dialog
locale/fr-fr/day_16_month_12_births.dialog
locale/fr-fr/day_16_month_12_deaths.dialog
locale/fr-fr/day_16_month_12_events.dialog
locale/fr-fr/day_16_month_1_births.dialog
locale/fr-fr/day_16_month_1_deaths.dialog
locale/fr-fr/day_16_month_1_events.dialog
locale/fr-fr/day_16_month_2_births.dialog
locale/fr-fr/day_16_month_2_deaths.dialog
locale/fr-fr/day_16_month_2_events.dialog
locale/fr-fr/day_16_month_3_births.dialog
locale/fr-fr/day_16_month_3_deaths.dialog
locale/fr-fr/day_16_month_3_events.dialog
locale/fr-fr/day_16_month_4_births.dialog
locale/fr-fr/day_16_month_4_deaths.dialog
locale/fr-fr/day_16_month_4_events.dialog
locale/fr-fr/day_16_month_5_births.dialog
locale/fr-fr/day_16_month_5_deaths.dialog
locale/fr-fr/day_16_month_5_events.dialog
locale/fr-fr/day_16_month_6_births.dialog
locale/fr-fr/day_16_month_6_deaths.dialog
locale/fr-fr/day_16_month_6_events.dialog
locale/fr-fr/day_16_month_7_births.dialog
locale/fr-fr/day_16_month_7_deaths.dialog
locale/fr-fr/day_16_month_7_events.dialog
locale/fr-fr/day_16_month_8_births.dialog
locale/fr-fr/day_16_month_8_deaths.dialog
locale/fr-fr/day_16_month_8_events.dialog
locale/fr-fr/day_16_month_9_births.dialog
locale/fr-fr/day_16_month_9_deaths.dialog
locale/fr-fr/day_16_month_9_events.dialog
locale/fr-fr/day_17_month_10_births.dialog
locale/fr-fr/day_17_month_10_deaths.dialog
locale/fr-fr/day_17_month_10_events.dialog
locale/fr-fr/day_17_month_11_births.dialog
locale/fr-fr/day_17_month_11_deaths.dialog
locale/fr-fr/day_17_month_11_events.dialog
locale/fr-fr/day_17_month_12_births.dialog
locale/fr-fr/day_17_month_12_deaths.dialog
locale/fr-fr/day_17_month_12_events.dialog
locale/fr-fr/day_17_month_1_births.dialog
locale/fr-fr/day_17_month_1_deaths.dialog
locale/fr-fr/day_17_month_1_events.dialog
locale/fr-fr/day_17_month_2_births.dialog
locale/fr-fr/day_17_month_2_deaths.dialog
locale/fr-fr/day_17_month_2_events.dialog
locale/fr-fr/day_17_month_3_births.dialog
locale/fr-fr/day_17_month_3_deaths.dialog
locale/fr-fr/day_17_month_3_events.dialog
locale/fr-fr/day_17_month_4_births.dialog
locale/fr-fr/day_17_month_4_deaths.dialog
locale/fr-fr/day_17_month_4_events.dialog
locale/fr-fr/day_17_month_5_births.dialog
locale/fr-fr/day_17_month_5_deaths.dialog
locale/fr-fr/day_17_month_5_events.dialog
locale/fr-fr/day_17_month_6_births.dialog
locale/fr-fr/day_17_month_6_deaths.dialog
locale/fr-fr/day_17_month_6_events.dialog
locale/fr-fr/day_17_month_7_births.dialog
locale/fr-fr/day_17_month_7_deaths.dialog
locale/fr-fr/day_17_month_7_events.dialog
locale/fr-fr/day_17_month_8_births.dialog
locale/fr-fr/day_17_month_8_deaths.dialog
locale/fr-fr/day_17_month_8_events.dialog
locale/fr-fr/day_17_month_9_births.dialog
locale/fr-fr/day_17_month_9_deaths.dialog
locale/fr-fr/day_17_month_9_events.dialog
locale/fr-fr/day_18_month_10_births.dialog
locale/fr-fr/day_18_month_10_deaths.dialog
locale/fr-fr/day_18_month_10_events.dialog
locale/fr-fr/day_18_month_11_births.dialog
locale/fr-fr/day_18_month_11_deaths.dialog
locale/fr-fr/day_18_month_11_events.dialog
locale/fr-fr/day_18_month_12_births.dialog
locale/fr-fr/day_18_month_12_deaths.dialog
locale/fr-fr/day_18_month_12_events.dialog
locale/fr-fr/day_18_month_1_births.dialog

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

📝 Coding Plan

Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

feat: add fr-fr locale

b2cbf50

github-actions bot added the feature label Mar 17, 2026

goldyfruit added 2 commits March 16, 2026 21:20

fix: polish fr-fr history locale

eb0a79b

Refresh fr-fr history corpus from upstream

f21eb4c

JarbasAl merged commit 2e2f729 into OpenVoiceOS:dev Mar 17, 2026
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add fr-fr locale#45

feat: add fr-fr locale#45
JarbasAl merged 3 commits intoOpenVoiceOS:devfrom
goldyfruit:feat/fr-fr-locale

goldyfruit commented Mar 17, 2026

Uh oh!

coderabbitai bot commented Mar 17, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

goldyfruit commented Mar 17, 2026

Summary

Notes

Validation

Uh oh!

coderabbitai bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Mar 17, 2026 •

edited

Loading