-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add a working example of drag-drop sortable MultiSelect values #3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Can we at least add the index prop? It's a tiny change, but without it no one can implement functionality like this. |
this is awesome, hoping for this change! |
This is a common usage for the |
Created PR and sample project for this purpose. |
Yeah please merge this - this is excellent! |
react-sortable-hoc package not working due to index prop and issue as below mentioned. Waiting on to get new package..... |
💥 No ChangesetLatest commit: 37286f1 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. |
Nice 😀 I had some issues fixing the conflicts on this branch locally so I've merged it into another one in the main repo for now, will PR that separately to get this live. Thanks for your work! |
Any updates on this, is it now part of the package? and if it is, where can I find the documentation for it? |
I found an example here https://react-select.netlify.app/advanced |
This uses the
react-sortable-hoc
package and is the same approach as #2284. It only makes two small line change tosreact-select
itself.I think with this we could close #1606, #2284, and #3223.