Skip to content

Add a working example of drag-drop sortable MultiSelect values #3645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 2, 2019

Conversation

gunn
Copy link
Contributor

@gunn gunn commented Jun 23, 2019

This uses the react-sortable-hoc package and is the same approach as #2284. It only makes two small line change tos react-select itself.

I think with this we could close #1606, #2284, and #3223.

@gunn
Copy link
Contributor Author

gunn commented Jul 9, 2019

Can we at least add the index prop? It's a tiny change, but without it no one can implement functionality like this.

@JedWatson @gwyneplaine

@bgalek
Copy link

bgalek commented Jul 17, 2019

this is awesome, hoping for this change!

@tonytangau
Copy link
Contributor

This is a common usage for the react-select users. Like @gunn asked, can we at least have the index added, so developers can DIY their drag and drop if this is not planned to be supported out of the box. It's a trivial change but provides huge value for the users.

@tonytangau
Copy link
Contributor

Created PR and sample project for this purpose.

@kroeberk
Copy link

Yeah please merge this - this is excellent!

@subbaraovnrt
Copy link

react-sortable-hoc package not working due to index prop and issue as below mentioned. Waiting on to get new package.....

47af78d

@JedWatson JedWatson changed the base branch from master to sortable-example October 2, 2019 06:22
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2019

💥 No Changeset

Latest commit: 37286f1

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

@JedWatson JedWatson merged commit 763b8f3 into JedWatson:sortable-example Oct 2, 2019
@JedWatson
Copy link
Owner

Nice 😀

I had some issues fixing the conflicts on this branch locally so I've merged it into another one in the main repo for now, will PR that separately to get this live.

Thanks for your work!

@Shaker-Hamdi
Copy link

Any updates on this, is it now part of the package? and if it is, where can I find the documentation for it?

@danieljaguiar
Copy link

Any updates on this, is it now part of the package? and if it is, where can I find the documentation for it?

I found an example here https://react-select.netlify.app/advanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants