-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Adding index sortable example #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@aschmoe this looks great! I'm about to publish a new patch version with other small fixes, and don't have time to review this fully before then but will come back to it asap. Would you mind amending the PR to not include the changes to the build files please? Thanks! |
35e895a
to
8c308fa
Compare
@JedWatson build files have been removed (though I've just realized not |
8c308fa
to
acacbdd
Compare
@JedWatson when could I expect a release with this PR being merged? |
@aschmoe - Really like this! One thing I noticed is that when clicking on an option to drag it, it causes the select input to open. Is it possible/desirable to prevent this, perhaps using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @aschmoe
Please resolve the conflict, then this is good to merge
A useful example to have, can we get this conflict resolved so that it can be merged? |
Thanks everyone who had a hand in this - with #3792 it's finally live |
RE: #91
Adds react-sortable-hoc example, adds index prop to ValueComponent
Work largely done by @pwhipp