Skip to content

Add index for multi select values #3727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Conversation

tonytangau
Copy link
Contributor

This change is for users with drag and drop requirements.

@tonytangau
Copy link
Contributor Author

Created a drag and drop multi select example based on this PR: sortable-select

@ttttsai
Copy link

ttttsai commented Aug 22, 2019

This looks great, could we merge this? @JedWatson @gwyneplaine

@kroeberk
Copy link

Please merge this. This is a great and simple implementation.

@JedWatson
Copy link
Owner

This looks good, thanks @tonytangau (and sorry for the delayed review!)

If you're up for it, adding your example from your sortable-select repo to the docs would be a great addition to help people understand how to use this feature.

Please open a PR for the "advanced" page if you're up for it!

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2019

🦋 Changeset is good to go

Latest commit: bc0aabc

We got this.

Not sure what this means? Click here to learn what changesets are.

@JedWatson JedWatson merged commit a575a3c into JedWatson:master Oct 2, 2019
@gunn
Copy link
Contributor

gunn commented Oct 2, 2019

Glad we have this in now.
@JedWatson my PR, which this one comes from, has an example added to the docs too - #3645

@JedWatson
Copy link
Owner

Hey @gunn yeah, I found that after merging this :) working to pull your PR into master now, thanks for that!

@gunn
Copy link
Contributor

gunn commented Oct 4, 2019

Awesome. Thank you @JedWatson.

@loopmode
Copy link

loopmode commented Jan 20, 2020

Hey guys. Thanks for adding the index, it really helps! (And not only in drag+drop scenarios :))

Not sure whether this is the right place This is probably the wrong place... but it would be great to add this to @types/react-select as well! (in MultiValue.d.ts)
Is somebody here affiliated with the types package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants