refactor: compile contracts cli #3798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouhanseng
force-pushed
the
hancheng/fix-contract-package
branch
from
6b12b2e to
bc23a85
Compare
zhouhanseng
commented
Jul 29, 2021
zhouhanseng
commented
Jul 29, 2021
| @@ -12,8 +13,11 @@ function run(webpack: TaskFunction, cb: TaskFunctionCallback) { | |||
| return shell.cwd(cwd)`${cmd}` | |||
| } | |||
|
|
|||
| export const codegenGuardWatch = series(codegen, parallel(codegenWatch, run.bind(null, extensionWatch))) | |||
| export const codegenGuard = series(codegen, run.bind(null, extension)) | |||
| export const codegenGuardWatch: Undertaker.TaskFunction = series( | |||
There was a problem hiding this comment.
The inferred type of 'codegenGuardWatch' cannot be named without a reference to '.pnpm/@[email protected]/node_modules/@types/undertaker'. This is likely not portable. A type annotation is necessary.
There was a problem hiding this comment.
I'd prefer to revert this change because this package will not be type-checked.
septs
reviewed
Jul 29, 2021
|
|
||
| // add to git stage | ||
| run(ABIS_PATH, 'git', 'add', '.') | ||
| run(GENERATED_PATH, 'git', 'add', '.') | ||
| shell`${ABIS_PATH}, 'git', 'add', '.'` |
There was a problem hiding this comment.
@Jack-Works Why remove run() in e523a09 ?
There was a problem hiding this comment.
@zhouhanseng you should copy run from e523a09 into this folder. The content in @masknet/cli is not designed to be compiled or exported.
|
@zhouhanseng please revert the irrelated change, just copy |
zhouhanseng
force-pushed
the
hancheng/fix-contract-package
branch
from
c149703 to
7a03829
Compare
septs
approved these changes
Jul 30, 2021
Jack-Works
approved these changes
Jul 30, 2021
yanzhihong23
added a commit
that referenced
this pull request
Aug 4, 2021
* develop: (93 commits) chore: add no-var rule (#3846) feat: the Risk Warning Dialog (#3833) fix(twitter): tweet selector fails to get link-only tweet content (#3837) chore: cleanup try-catch (#3840) chore: simplify urlcat builder (#3843) fix: parseint radix unset (#3844) chore: improve eslint (#3835) feat: introduce arbitrum network (#3558) fix: show nan in dashboard asset list (#3828) chore: simplify typing (#3825) refactor: revamp redpacket (#3809) feat: enable new dashboard in beat (#3826) fix: eslint (#3823) Update flags.ts (#3824) refactor: add v2_enabled flag (#3820) RFC: new payload v-37 and TypedMessage binary format (#2623) fix: bridge is down (#3821) feat: set experimentalMark on 3 plugins (#3669) fix: snapshot break down (#3814) refactor: compile contracts cli (#3798) ...
guanbinrui
pushed a commit
that referenced
this pull request
Aug 6, 2021
* refactor: compile contracts cli * chore: remove unused packages * chore: reply code review * chore: reply code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix:
Cannot find module '../cli/utils' or its corresponding type declarations.ts(2307)