Merge branch 'develop' into feature/dashboard-backup

* develop: (93 commits)
  chore: add no-var rule (#3846)
  feat: the Risk Warning Dialog (#3833)
  fix(twitter): tweet selector fails to get link-only tweet content (#3837)
  chore: cleanup try-catch (#3840)
  chore: simplify urlcat builder (#3843)
  fix: parseint radix unset (#3844)
  chore: improve eslint (#3835)
  feat: introduce arbitrum network (#3558)
  fix: show nan in dashboard asset list (#3828)
  chore: simplify typing (#3825)
  refactor: revamp redpacket (#3809)
  feat: enable new dashboard in beat (#3826)
  fix: eslint (#3823)
  Update flags.ts (#3824)
  refactor: add v2_enabled flag (#3820)
  RFC: new payload v-37 and TypedMessage binary format (#2623)
  fix: bridge is down (#3821)
  feat: set experimentalMark on 3 plugins (#3669)
  fix: snapshot break down (#3814)
  refactor: compile contracts cli (#3798)
  ...

Author: yanzhihong23

.circleci/config.yml

@@ -41,12 +41,9 @@ jobs:
     executor: maskbook_node
     steps:
       - restore_workspace
-      - run:
-          name: Install zip
-          command: sudo apt-get install zip
       - run:
           name: Build Maskbook
-          command: npx build-ci
+          command: npx gulp build-ci
       - store_artifacts:
           path: Maskbook.base.zip
           destination: /Maskbook.base.zip

.eslintrc.json

@@ -12,6 +12,7 @@
         "constructor-super": "error",
         "dot-notation": "error",
         "eqeqeq": "error",
+        "no-var": "error",
         "no-bitwise": "error",
         "no-debugger": "error",
         "no-eval": "error",

.github/workflows/build.yml

@@ -43,7 +43,7 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-webpack-${{ hashFiles('**/pnpm-lock.yaml') }}
       - run: npx pnpm install
-      - run: npx build-ci
+      - run: npx gulp build-ci
       - name: Upload `Maskbook.base.zip`
         uses: actions/upload-artifact@v2
         with:

.github/workflows/linters.yml

@@ -28,7 +28,7 @@ jobs:
           key: ${{ runner.os }}-node-${{ hashFiles('**/pnpm-lock.yaml') }}
           restore-keys: ${{ runner.os }}-node-
       - run: npx pnpm install
-      - run: npx locale-kit
+      - run: npx gulp locale-kit
   type-check:
     runs-on: ubuntu-20.04
     steps:
@@ -58,7 +58,7 @@ jobs:
             ${{ runner.os }}-tsc-${{ hashFiles('packages/**/tsconfig.json') }}-${{ hashFiles('pnpm-lock.yaml') }}
             ${{ runner.os }}-tsc-${{ hashFiles('packages/**/tsconfig.json') }}
       - run: npx pnpm install
-      - run: npx build -- echo "Check tsc"
+      - run: npx gulp codegen
   eslint:
     runs-on: ubuntu-20.04
     needs: [prettier, locale-kit, type-check]

.gitignore

@@ -22,6 +22,7 @@ i18n_generated.d.ts.map
 # Build out
 dist
 build
+/build-*
 storybook-static
 packages/netlify/snowpack/
 /Maskbook.*.zip

.i18n-codegen.json

@@ -49,6 +49,18 @@
                 "trans": "Translate",
                 "sourceMap": "inline"
             }
+        },
+        {
+            "input": "./packages/plugins/Wallet/src/locales/en.json",
+            "output": "./packages/plugins/Wallet/src/locales/i18n_generated",
+            "parser": "i18next",
+            "generator": {
+                "type": "i18next/react-hooks",
+                "hooks": "useI18N",
+                "namespace": "com.maskbook.wallet",
+                "trans": "Translate",
+                "sourceMap": "inline"
+            }
         }
     ]
 }

.vscode/schema/constants.json

@@ -19,7 +19,19 @@
     "minProperties": 1,
     "definitions": {
         "chain-id": {
-            "enum": ["Mainnet", "Ropsten", "Rinkeby", "Gorli", "Kovan", "BSC", "BSCT", "Matic", "Mumbai"]
+            "enum": [
+                "Mainnet",
+                "Ropsten",
+                "Rinkeby",
+                "Gorli",
+                "Kovan",
+                "BSC",
+                "BSCT",
+                "Matic",
+                "Mumbai",
+                "Arbitrum",
+                "Arbitrum_Rinkeby"
+            ]
         },
         "primitive": {
             "type": ["string", "integer", "boolean", "null"]

.vscode/settings.json

@@ -53,7 +53,7 @@
         "editor.defaultFormatter": "redhat.vscode-yaml"
     },
     "[markdown]": {
-        "editor.defaultFormatter": "DavidAnson.vscode-markdownlint",
+        "editor.defaultFormatter": "esbenp.prettier-vscode",
         "editor.wordWrap": "on",
         "editor.quickSuggestions": true
     }

.vscode/tasks.recommended.json

@@ -5,10 +5,9 @@
     "tasks": [
         {
             "type": "npm",
-            "script": "ts",
+            "script": "codegen",
             "problemMatcher": ["$tsc-watch"],
             "label": "Background TypeScript compiler",
-            "detail": "dev -- echo Starting TypeScript compiler...",
             "isBackground": true,
             "group": "build",
             "presentation": {

docs/plugin-development-guide.md

@@ -9,6 +9,8 @@ maintainer:
 
 ## Minimum File Structure
 
+`packages/plugins/example/src` is an example of this structure.
+
 ```plaintext
 packages/maskbook/src/plugins/{your-plugin-name}
 ├── README.md           # see `README driven development`
@@ -32,12 +34,20 @@ The file need to provide this information:
 - Reference resource list
 - Known issues / Caveats
 
+## Registration
+
+Import your plugin definition at: `packages/maskbook/src/plugin-infra/register.ts`.
+
+If your plugin is defined at `packages/plugins/*` instead of `packages/maskbook/src/plugins/*`, please make sure you have set up the monorepo correctly.
+
+Plugins defined at `packages/plugins/*` and compatible with the isolated dashboard should also be registered in `packages/dashboard/src/initialization/plugins.ts`
+
 ## Plugin APIs
 
 - Plugin definition: `packages/plugin-infra/src/types.ts`
 - Database: `createPluginDatabase` in `packages/maskbook/src/database/Plugin/wrap-plugin-database.ts`
-- Event emitter: `createPluginMessage` in `packages/maskbook/src/plugins/utils/createPluginMessage.ts`
-- RPC: `createPluginRPC` in `packages/maskbook/src/plugins/utils/createPluginRPC.ts`
+- Message emitter: `createPluginMessage` in `packages/plugin-infra/src/utils/message.ts`
+- RPC: `createPluginRPC` in `packages/plugin-infra/src/utils/rpc.ts`
 - Metadata reader: `createTypedMessageMetadataReader` in `packages/maskbook/src/protocols/typed-message/metadata.ts`
 - React renderer with metadata reader: `createRenderWithMetadata` in `packages/maskbook/src/protocols/typed-message/metadata.ts`