RFC: new payload v-37 and TypedMessage binary format #2623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
guanbinrui,
jk234ert,
septs and
zhouhanseng
Jack-Works
force-pushed
the
rfc/next-payload
branch
from
0e90cdb to
b81f74c
Compare
|
Do you guys prefer CBOR(RFC8949) over MessagePack? I found that format but also found this https://diziet.dreamwidth.org/6568.html. FYI, for this specific format, size is the most important thing. It's acceptable to have a longer encode/decode time. |
Jack-Works
force-pushed
the
rfc/next-payload
branch
from
148ea16 to
054340a
Compare
septs
reviewed
Jul 15, 2021
septs
reviewed
Jul 15, 2021
|
@septs only TypedMessage binary format is ready for review. |
septs
reviewed
Jul 16, 2021
septs
reviewed
Jul 17, 2021
septs
reviewed
Jul 17, 2021
septs
reviewed
Jul 17, 2021
septs
reviewed
Jul 17, 2021
septs
reviewed
Jul 17, 2021
septs
reviewed
Jul 17, 2021
Co-authored-by: Septs <[email protected]>
Co-authored-by: Septs <[email protected]>
septs
reviewed
Jul 17, 2021
Co-authored-by: Septs <[email protected]>
Tlaster
previously requested changes
Jul 19, 2021
Co-authored-by: Tlaster <[email protected]>
septs
approved these changes
Jul 20, 2021
|
After discussion, I need to rewrite this. |
septs
approved these changes
Jul 26, 2021
yisiliu
approved these changes
Aug 2, 2021
guanbinrui
approved these changes
Aug 2, 2021
himself65
approved these changes
Aug 2, 2021
yanzhihong23
added a commit
that referenced
this pull request
Aug 3, 2021
* develop: feat: introduce arbitrum network (#3558) fix: show nan in dashboard asset list (#3828) chore: simplify typing (#3825) refactor: revamp redpacket (#3809) feat: enable new dashboard in beat (#3826) fix: eslint (#3823) Update flags.ts (#3824) refactor: add v2_enabled flag (#3820) RFC: new payload v-37 and TypedMessage binary format (#2623) fix: bridge is down (#3821) feat: set experimentalMark on 3 plugins (#3669)
yanzhihong23
added a commit
that referenced
this pull request
Aug 4, 2021
* develop: (93 commits) chore: add no-var rule (#3846) feat: the Risk Warning Dialog (#3833) fix(twitter): tweet selector fails to get link-only tweet content (#3837) chore: cleanup try-catch (#3840) chore: simplify urlcat builder (#3843) fix: parseint radix unset (#3844) chore: improve eslint (#3835) feat: introduce arbitrum network (#3558) fix: show nan in dashboard asset list (#3828) chore: simplify typing (#3825) refactor: revamp redpacket (#3809) feat: enable new dashboard in beat (#3826) fix: eslint (#3823) Update flags.ts (#3824) refactor: add v2_enabled flag (#3820) RFC: new payload v-37 and TypedMessage binary format (#2623) fix: bridge is down (#3821) feat: set experimentalMark on 3 plugins (#3669) fix: snapshot break down (#3814) refactor: compile contracts cli (#3798) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.