Skip to content

Realtek-rtl8195am-Network Socket Updates #9070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

AdamZhang0124
Copy link
Contributor

This PR addresses the issue of #8124.
It updates and enriches the wifi connection error type to adapt the Network Socket test plan requirement.
In the meantime, it increases the heap size that allows the transmission of larger packet size.

Description

Increase heap size in lwipstack\mbed_lib.json.
Modify and enrich wifi connection error types in TARGET_AMEBA\RTWInterface.cpp
Add new parameters in TARGET_AMEBA\RTWInterface.h

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a heads up @ARMmbed/mbed-os-maintainers (you administer the ciarmcom review bot I think?), this doesn't include any tool changes, only config changes to the library. So @ARMmbed/mbed-os-tools won't do a full code review on this unless otherwise requested.

@cmonr
Copy link
Contributor

cmonr commented Dec 12, 2018

you administer the ciarmcom review bot I think?

Yup.

@adbridge I'm confused as well as to why tools were poked for a review.

@bridadan
Copy link
Contributor

@cmonr If I had to guess, there's some rule that says "poke tools team if any json is changed". There are some json files that are good to have a review (target.json, anything in /tools, etc).

Cruz Monrreal and others added 9 commits December 12, 2018 16:55
Disable MPU on RT1050 due to memory map
…ning

mbed_fault_handler: fix build warning
…-in-targets-json

Fix duplicate 'overrides' keys in targets.json config file
…et_tcp

Fix test-netsocket-tcp greentea test build fails.
…nitions

Change enet_tasklet declarations to match code
[Seeed Arch MAX] Add Mbed OS 5 support
W7500x target ADC 6 and 7 not implemented
@cmonr
Copy link
Contributor

cmonr commented Dec 13, 2018

@AdamZhang0124 Could you take a look at your PR's commit history? It looks as if you merged with master, which isn't supported by our release process.

Instead, to update a PR, you need to do a rebase.

@AdamZhang0124 AdamZhang0124 deleted the realtek-rtl8195am-NetworkSocket_Updates branch December 13, 2018 07:01
@adbridge
Copy link
Contributor

@bridadan The rules for the tools team are:

"tools" : ["mbed-os-tools"],
"docs/design-documents/tools" : ["mbed-os-tools", "mbed-docs"],

So any changes under the tools directory will cause you to be tagged.

@bridadan
Copy link
Contributor

@adbridge understood. Although the original changes have been removed, I remember there not being any changes under the tools or docs directories. Not a big deal, but just wanted to alert you in case the bot was having issues/rule mismatches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.