Realtek-rtl8195am-Network_Socket_Updates

[AdamZhang0124]

This PR addresses the issue of #8124.
It updates and enriches the wifi connection error type to adapt the Network Socket test plan requirement.
In the meantime, it increases the heap size that allows the transmission of larger packet size.

Description

1. Increase heap size in lwipstack\mbed_lib.json to fulfill bursty TCP and UDP transmission requirement.
2. Modify and enrich wifi connection error types in TARGET_AMEBA\RTWInterface.cpp to adapt the decision logic of the wifi test cases.
3. Add new static constants in TARGET_AMEBA\RTWInterface.h, including 'SSID_MAX_LENGTH', 'PASSPHRASE_MAX_LENGTH' and 'PASSPHRASE_MIN_LENGTH' to help verifying the validity of ssid and passphrase.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

[AdamZhang0124]

Hi @0xc0170 and @cmonr ,
Thank you for the comments on the pull request #9070 .
I have amended the pull request and removed the redundant commits. Please help review it again. Sorry for the inconvenience caused.

[ciarmcom]

@AdamZhang0124, thank you for your changes.
@ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

Thanks for the update, looks better. Realtek-rtl8195am-Network Socket Updates - can you amend to your commits what updates are being done

from the previous PR: Increase heap size in lwipstack\mbed_lib.json. Modify and enrich wifi connection error types in TARGET_AMEBA\RTWInterface.cpp Add new parameters in TARGET_AMEBA\RTWInterface.h. This would be helpful to have in the commit message. Why we are increasing heap size? Why are new parameters needed in RTWInterface, and similar questions answered there.

[0xc0170]

Describe changes in the commit message (provide details)

[AdamZhang0124]

Thanks for the update, looks better. Realtek-rtl8195am-Network Socket Updates - can you amend to your commits what updates are being done

from the previous PR: Increase heap size in lwipstack\mbed_lib.json. Modify and enrich wifi connection error types in TARGET_AMEBA\RTWInterface.cpp Add new parameters in TARGET_AMEBA\RTWInterface.h. This would be helpful to have in the commit message. Why we are increasing heap size? Why are new parameters needed in RTWInterface, and similar questions answered there.

Hi @0xc0170, thanks for the feedback. I have amended the commit message. Please let me know if there is anything need to be further explained. Thanks.

[0xc0170]

@AdamZhang0124 not yet pushed? I dont see any change here as for now

[AdamZhang0124]

@AdamZhang0124 not yet pushed? I dont see any change here as for now

Up on request, I have commented the reasons of the file changes under Description section already.
In addition, this pull request mainly aims to fix the the issue of #8124 . More detailed information and change history can be found at the comment area of #8124 . Thanks.

[0xc0170]

That is correct, it is good to have it described here.
However for people working offline, or basically outside of Github, there is no reference to the issue, this pull request only very short sentence that does not say much. It's worth describing it in the commit msg (I often copy commit message to the Pull request description). Our docs reference this article as a guide for commit messages: https://chris.beams.io/posts/git-commit/#seven-rules

If you can quickly amend your commit msg, we shall start Ci right away

[AdamZhang0124]

That is correct, it is good to have it described here.
However for people working offline, or basically outside of Github, there is no reference to the issue, this pull request only very short sentence that does not say much. It's worth describing it in the commit msg (I often copy commit message to the Pull request description). Our docs reference this article as a guide for commit messages: https://chris.beams.io/posts/git-commit/#seven-rules

If you can quickly amend your commit msg, we shall start Ci right away

@0xc0170 Oh, I see what you mean. I thought you mean the description on this page is not clear.
After checking, I do have missed out the commit message. Sorry about that.
Now I am looking for a way to add it. It seems like I cannot edit commit msg directly at here. So, instead of submit a new pull request, do you have more convenient and straight forward ways to do it?
Thanks.

[0xc0170]

The last commit can be amended git commit --amend or git rebase -i HEAD~1 in this case. Then you need to force push to your branch.

[AdamZhang0124]

The last commit can be amended git commit --amend or git rebase -i HEAD~1 in this case. Then you need to force push to your branch.

@0xc0170
Thanks a lot for the help. I have amended the commit message. Please kindly help to check if it is ok. Thanks.

[0xc0170]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts