-
Notifications
You must be signed in to change notification settings - Fork 3k
Realtek-rtl8195am-Network_Socket_Updates #9084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Realtek-rtl8195am-Network_Socket_Updates #9084
Conversation
@AdamZhang0124, thank you for your changes. |
Thanks for the update, looks better. from the previous PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe changes in the commit message (provide details)
Hi @0xc0170, thanks for the feedback. I have amended the commit message. Please let me know if there is anything need to be further explained. Thanks. |
@AdamZhang0124 not yet pushed? I dont see any change here as for now |
Up on request, I have commented the reasons of the file changes under Description section already. |
That is correct, it is good to have it described here. If you can quickly amend your commit msg, we shall start Ci right away |
@0xc0170 Oh, I see what you mean. I thought you mean the description on this page is not clear. |
The last commit can be amended |
This PR addresses the issue of ARMmbed#8124. It updates and enriches the wifi connection error type to adapt the Network Socket test plan requirement. In the meantime, it increases the heap size that allows the transmission of larger packet size. Description 1. Increase heap size in lwipstack\mbed_lib.json to fulfill bursty TCP and UDP transmission requirement. 2. Modify and enrich wifi connection error types in TARGET_AMEBA\RTWInterface.cpp to adapt the decision logic of the wifi test cases. 3. Add new static constants in TARGET_AMEBA\RTWInterface.h, including 'SSID_MAX_LENGTH', 'PASSPHRASE_MAX_LENGTH' and 'PASSPHRASE_MIN_LENGTH' to help verifying the validity of ssid and passphrase. Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Docs update [ ] Test update [ ] Breaking change
c417248
to
1422379
Compare
@0xc0170 |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This PR addresses the issue of #8124.
It updates and enriches the wifi connection error type to adapt the Network Socket test plan requirement.
In the meantime, it increases the heap size that allows the transmission of larger packet size.
Description
Pull request type