Skip to content

Fix test-netsocket-tcp greentea test build fails. #9049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2018
Merged

Fix test-netsocket-tcp greentea test build fails. #9049

merged 1 commit into from
Dec 12, 2018

Conversation

KariHaapalehto
Copy link
Contributor

Description

main.cpp was missing comma at the end of line.
Tested locally

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@KariHaapalehto
Fix test-netsocket-tcp greentea test build fails.
e502675 
main.cpp was missing comma at the end of line.
@KariHaapalehto
Copy link
Contributor Author

KariHaapalehto commented Dec 11, 2018 •
edited
Loading

please review @michalpasztamobica

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2018

How did this go through CI? 🙄

@KariHaapalehto
Copy link
Contributor Author

Good question. I spotted this error from ip-core jenkins jobs.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 11, 2018

@ARMmbed/mbed-os-test Can you review this bug please?

@0xc0170 0xc0170 requested a review from a team December 11, 2018 11:38
@KariHaapalehto
Copy link
Contributor Author

This went through CI, because it was under MBED_EXTENDED_TESTS-flag and at nightly builds/test MBED_EXTENDED_TESTS aren't done at the moment. I just head that MBED_EXTENDED_TESTS tests are coming to nightly build soon.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 12, 2018

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 34007bb into ARMmbed:master Dec 12, 2018
@KariHaapalehto KariHaapalehto deleted the fix_tests_netsocket_tcp branch December 14, 2018 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@michalpasztamobica michalpasztamobica michalpasztamobica approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KariHaapalehto @0xc0170 @mbed-ci @cmonr @OPpuolitaival @michalpasztamobica