Skip to content

Revert "Remove MTB_STM_S2LP target" #12846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2020
Merged

Revert "Remove MTB_STM_S2LP target" #12846

merged 1 commit into from
Apr 23, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Apr 22, 2020 •
edited
Loading

Summary of changes

This reverts commit 10ca248 (PR #12810). User internally in testing, revert must be coordinated with @ARMmbed/mbed-os-mesh team

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170 0xc0170 requested a review from MarceloSalazar April 22, 2020 12:48
@ciarmcom ciarmcom requested review from a team April 22, 2020 13:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-ipcore please review.

@0xc0170 0xc0170 removed request for a team April 22, 2020 13:11
@0xc0170
Copy link
Contributor Author

0xc0170 commented Apr 22, 2020

CI started

MarceloSalazar
MarceloSalazar approved these changes Apr 22, 2020
View reviewed changes
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert looks correct (pending CI to confirm this)

adbridge
adbridge approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mbed-ci
Copy link

mbed-ci commented Apr 22, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 4021b1a into ARMmbed:master Apr 23, 2020
@0xc0170 0xc0170 deleted the revert_s2lp_target branch April 23, 2020 06:13
@mergify mergify bot removed the ready for merge label Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @ciarmcom @mbed-ci @MarceloSalazar @adbridge