Skip to content

sanitycheck: error on duplicate board identifiers #27549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 15, 2020
Merged

sanitycheck: error on duplicate board identifiers #27549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa6972c
boards: ODROID-GO: fix board identifier
nashif Aug 13, 2020
a49e092
boards: LPCXpresso55S69: remove duplicate identifier
nashif Aug 13, 2020
0276918
sanitycheck: error on duplicate board identifier
nashif Aug 13, 2020
e308c75
boards: lpcxpresso55s69_cpu1: disable sanitycheck
nashif Sep 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion boards/arm/lpcxpresso55s69/lpcxpresso55s69_cpu1.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,13 @@
# SPDX-License-Identifier: Apache-2.0
#

identifier: lpcxpresso55s69_cpu0
identifier: lpcxpresso55s69_cpu1
name: NXP LPCXpresso55S69
type: mcu
arch: arm
ram: 64
flash: 256
sanitycheck: false
toolchain:
- zephyr
- gnuarmemb
Expand Down
2 changes: 1 addition & 1 deletion boards/xtensa/odroid_go/odroid_go.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
identifier: esp32
identifier: odroid-go
name: ODROID-GO
type: mcu
arch: xtensa
Expand Down
3 changes: 3 additions & 0 deletions scripts/sanity_chk/sanitylib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2600,6 +2600,9 @@ def add_configurations(self):
try:
platform = Platform()
platform.load(file)
if platform.name in [p.name for p in self.platforms]:
logger.error(f"Duplicate platform {platform.name} in {file}")
raise Exception(f"Duplicate platform identifier {platform.name} found")
if platform.sanitycheck:
self.platforms.append(platform)
if platform.default:
Expand Down