Skip to content

sanitycheck: error on duplicate board identifiers #27549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 15, 2020
Merged

sanitycheck: error on duplicate board identifiers #27549

merged 4 commits into from
Sep 15, 2020

Conversation

nashif
Copy link
Member

@nashif nashif commented Aug 13, 2020 •
edited
Loading

2 boards had duplicate identifiers, fix those and add a check in sanitycheck to error when such issues are found.

@nashif nashif requested a review from ydamigos as a code owner August 13, 2020 11:35
@nashif nashif requested a review from MaureenHelm as a code owner August 13, 2020 11:47
@nashif nashif changed the title boards: ODROID-GO: fix board identifier sanitycheck: error on duplicate board identifiers Aug 13, 2020
@nashif nashif requested a review from PerMac August 13, 2020 11:48
chrta
chrta reviewed Aug 13, 2020
View reviewed changes
@galak
Copy link
Contributor

galak commented Aug 13, 2020

LGTM, same question as @chrta regarding the commented out code.

@nashif nashif self-assigned this Aug 13, 2020
@jenmwms
Copy link
Contributor

jenmwms commented Aug 27, 2020

I don't know if it is a blocking issue, but there are some samples/ are getting cmake build error for the lpcxpresso55s69_cpu1, which I can reproduce locally. It works for lpcxpresso55s69_cpu0. Is that a problem?

@nashif
Copy link
Member Author

nashif commented Aug 27, 2020

I don't know if it is a blocking issue, but there are some samples/ are getting cmake build error for the lpcxpresso55s69_cpu1, which I can reproduce locally. It works for lpcxpresso55s69_cpu0. Is that a problem?

@jenmwms yes, can you please open a bug an assign it to @MaureenHelm ? :-)

@jenmwms jenmwms mentioned this pull request Aug 28, 2020
Closed
@jenmwms
Copy link
Contributor

jenmwms commented Aug 28, 2020

@jenmwms yes, can you please open a bug an assign it to @MaureenHelm ? :-)

Thanks for suggesting! Please see #27880 capturing this.

@github-actions github-actions bot added the area: Sanitycheck Sanitycheck has been renamed to Twister label Sep 15, 2020
@nashif
Copy link
Member Author

nashif commented Sep 15, 2020

lpcxpresso55s69_cpu1 needs some work still and it is preventing this PR from going in. Disabled sanitycheck for that board now (it never built in sanitycheck before anyways) until it is fixed but allowing the other fixes to go in so we catch issues that cause this to happen.

@abrodkin
Copy link
Contributor

nSIM part is already addressed here #28379, so should be dropped from this one.

abrodkin
abrodkin requested changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@abrodkin abrodkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of nsim part, as it's addressed here #28379 separately.

@nashif
Copy link
Member Author

nashif commented Sep 15, 2020 •
edited
Loading

Let's get rid of nsim part, as it's addressed here #28379 separately.

@abrodkin then you need to go approve that one.. :-)

@abrodkin
Copy link
Contributor

@nashif done!

@nashif
boards: ODROID-GO: fix board identifier
fa6972c 
Using the esp32 identifier which is wrong. Probably a copy/paste error.

Signed-off-by: Anas Nashif <[email protected]>
tejlmand added a commit to tejlmand/fw-nrfconnect-nrf that referenced this pull request Oct 2, 2020
@tejlmand
treewide: Update OSS projects revisions
5a0145f 
sdk-zephyr: pull/354/head
sdk-mcuboot: pull/120/head
sdk-mcumgr: pull/10/head
sdk-nrfxlib: pull/266/head

Summary of changes needed for this upmerge:

- modules: device: Const-ify all device driver instance pointers.

  See also ttps://github.com/zephyrproject-rtos/zephyr/pull/24873

- jenkins: remove --board-root zephyr/boards

  zephyr/boards are always part of sanity-check and with duplicate board
  checking with: zephyrproject-rtos/zephyr#27549
  this now results in CI failures.

- samples: whitelist -> allow

  sanitycheck: inclusive language

  change whitelist -> allow for all sample.yaml and testcase.yaml files

- scripts: ncs_commands: add hal_quicklogic to _BLOCKED_PROJECTS

  This is a vendor HAL for an SoC family not supported in NCS.

- doc: upmerge changes to docs

  Adjusted `CONFIG_BT_GATT_DIS` -> `CONFIG_BT_DIS` in docs.

- samples: remove GATT infix in conf files for applications and samples

- usb: hid: All hid_ops callbacks get device pointer.

  Updated usb_state.c to new hid_ops callbacks which includes the device
  pointer.

- cmake: bintools elfconvert

  Updated according to new toolchain abstraction.

- partition_manager: cmake: update regex for runner hex file

  The format of the runner yaml has changed. Update the regex used to
  replace the hex_file variable to match it.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
Signed-off-by: Torsten Rasmussen <[email protected]>
utzig pushed a commit to tejlmand/fw-nrfconnect-nrf that referenced this pull request Oct 6, 2020
@tejlmand @utzig
treewide: Update OSS projects revisions
159cde8 
sdk-zephyr: a4ead98051404e3b63845d9944b0c689162f1db1 (PR nrfconnect#354)
sdk-mcuboot: ec441e0a700280673e11f4e242ff5de696d4f962 (PR nrfconnect#120)
sdk-mcumgr: b3716c64bde95ea5911a36001fd8f8d4b46eb310 (PR nrfconnect#10)
sdk-nrfxlib: f1dd2ee (PR nrfconnect#266)

Summary of changes needed for this upmerge:

- modules: device: Const-ify all device driver instance pointers.

  See also zephyrproject-rtos/zephyr#24873

- jenkins: remove --board-root zephyr/boards

  zephyr/boards are always part of sanity-check and with duplicate board
  checking with: zephyrproject-rtos/zephyr#27549
  this now results in CI failures.

- samples: whitelist -> allow

  sanitycheck: inclusive language.

  change whitelist -> allow for all sample.yaml and testcase.yaml files.

- scripts: ncs_commands: add hal_quicklogic to _BLOCKED_PROJECTS

  This is a vendor HAL for an SoC family not supported in NCS.

- doc: upmerge changes to docs

  Adjusted `CONFIG_BT_GATT_DIS` -> `CONFIG_BT_DIS` in docs.

- samples: remove GATT infix in conf files for applications and samples

- usb: hid: All hid_ops callbacks get device pointer.

  Updated usb_state.c to new hid_ops callbacks which includes the device
  pointer.

- cmake: bintools elfconvert

  Updated according to new toolchain abstraction.

- partition_manager: cmake: update regex for runner hex file

  The format of the runner yaml has changed. Update the regex used to
  replace the hex_file variable to match it.

- spm: align with updated API for setting irq state

  The API for setting IRQ state has changed.
  Update to align with the new functionailty.

  Ref: NCSDK-6463

- nrf_desktop: using CONFIG_SYSTEM_CLOCK_WAIT_FOR_STABILITY=y

  Updated nrf_desktop applications to use upstream
  SYSTEM_CLOCK_WAIT_FOR_STABILITY instead of
  CLOCK_CONTROL_NRF_K32SRC_BLOCKING.

- dts/Kconfig: Remove HAS_DTS_I2C

  HAS_DTS_I2C is now selected by I2C and
  always used as I2C && HAS_DTS_I2C.

  It could then be purely removed.

- drivers: mpsl: clock_control: Provide nrfx_clock shim

  Replace clock_control_mpsl with nrfx_clock implementation which is
  using mpsl_clock API. This way standard clock_control driver is
  used and only thin, straightforward nrfx_clock API is replaced with
  implementation which is utilizing mpsl_clock API.

- mpsl: removing clock control in mpsl

- applications: nrf_desktop: Disable mem protection in mcuboot

  Disable HW stack protection in MCUBoot. This seems to cause
  problems as region protection migrates to application and can
  cause faults during kernel initialization.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
Signed-off-by: Torsten Rasmussen <[email protected]>
Signed-off-by: Pawel Dunaj <[email protected]>
Signed-off-by: Krzysztof Chruscinski <[email protected]>
mbolivar-nordic pushed a commit to nrfconnect/sdk-nrf that referenced this pull request Oct 6, 2020
@tejlmand @mbolivar-nordic
treewide: Update OSS projects revisions
11d05f5 
sdk-zephyr: a4ead98051404e3b63845d9944b0c689162f1db1 (PR #354)
sdk-mcuboot: ec441e0a700280673e11f4e242ff5de696d4f962 (PR #120)
sdk-mcumgr: b3716c64bde95ea5911a36001fd8f8d4b46eb310 (PR #10)
sdk-nrfxlib: f1dd2ee (PR #266)

Summary of changes needed for this upmerge:

- modules: device: Const-ify all device driver instance pointers.

  See also zephyrproject-rtos/zephyr#24873

- jenkins: remove --board-root zephyr/boards

  zephyr/boards are always part of sanity-check and with duplicate board
  checking with: zephyrproject-rtos/zephyr#27549
  this now results in CI failures.

- samples: whitelist -> allow

  sanitycheck: inclusive language.

  change whitelist -> allow for all sample.yaml and testcase.yaml files.

- scripts: ncs_commands: add hal_quicklogic to _BLOCKED_PROJECTS

  This is a vendor HAL for an SoC family not supported in NCS.

- doc: upmerge changes to docs

  Adjusted `CONFIG_BT_GATT_DIS` -> `CONFIG_BT_DIS` in docs.

- samples: remove GATT infix in conf files for applications and samples

- usb: hid: All hid_ops callbacks get device pointer.

  Updated usb_state.c to new hid_ops callbacks which includes the device
  pointer.

- cmake: bintools elfconvert

  Updated according to new toolchain abstraction.

- partition_manager: cmake: update regex for runner hex file

  The format of the runner yaml has changed. Update the regex used to
  replace the hex_file variable to match it.

- spm: align with updated API for setting irq state

  The API for setting IRQ state has changed.
  Update to align with the new functionailty.

  Ref: NCSDK-6463

- nrf_desktop: using CONFIG_SYSTEM_CLOCK_WAIT_FOR_STABILITY=y

  Updated nrf_desktop applications to use upstream
  SYSTEM_CLOCK_WAIT_FOR_STABILITY instead of
  CLOCK_CONTROL_NRF_K32SRC_BLOCKING.

- dts/Kconfig: Remove HAS_DTS_I2C

  HAS_DTS_I2C is now selected by I2C and
  always used as I2C && HAS_DTS_I2C.

  It could then be purely removed.

- drivers: mpsl: clock_control: Provide nrfx_clock shim

  Replace clock_control_mpsl with nrfx_clock implementation which is
  using mpsl_clock API. This way standard clock_control driver is
  used and only thin, straightforward nrfx_clock API is replaced with
  implementation which is utilizing mpsl_clock API.

- mpsl: removing clock control in mpsl

- applications: nrf_desktop: Disable mem protection in mcuboot

  Disable HW stack protection in MCUBoot. This seems to cause
  problems as region protection migrates to application and can
  cause faults during kernel initialization.

Signed-off-by: Håkon Øye Amundsen <[email protected]>
Signed-off-by: Torsten Rasmussen <[email protected]>
Signed-off-by: Pawel Dunaj <[email protected]>
Signed-off-by: Krzysztof Chruscinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrta chrta chrta approved these changes

@abrodkin abrodkin abrodkin approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@galak galak galak approved these changes

@jenmwms jenmwms jenmwms approved these changes

@PerMac PerMac PerMac approved these changes

@ydamigos ydamigos Awaiting requested review from ydamigos

@ruuddw ruuddw Awaiting requested review from ruuddw

Assignees

@nashif nashif

Labels
area: Boards area: Sanitycheck Sanitycheck has been renamed to Twister platform: NXP NXP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nashif @galak @jenmwms @abrodkin @chrta @MaureenHelm @PerMac