Skip to content

Get rid of old notebooks #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2025
Merged

Get rid of old notebooks #2897

merged 3 commits into from
Jun 19, 2025

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented Mar 7, 2025 •
edited
Loading

Fixes #2646.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.rst
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Mar 7, 2025
@DimitriPapadopoulos DimitriPapadopoulos force-pushed the LMDBStore_DBMStore branch 2 times, most recently from 2200387 to ff70421 Compare March 7, 2025 14:28
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review March 10, 2025 12:50
@DimitriPapadopoulos
Copy link
Contributor Author

BTW, should I renumber the cells? I think this could be deferred to a different PR, especially since numbering was already broken before thsi PR.

dstansby
dstansby reviewed Jun 18, 2025
View reviewed changes
Copy link
Contributor

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just delete these notebooks? They're old (8 years!), and always in the v2 branch if we need/want them.

@d-v-b
Copy link
Contributor

d-v-b commented Jun 18, 2025

+1 to deleting them

@DimitriPapadopoulos DimitriPapadopoulos changed the title Get rid of deprecated stores LMDBStore/DBMStore Get rid of old notebooks Jun 18, 2025
@dstansby dstansby enabled auto-merge (squash) June 19, 2025 08:26
@dstansby dstansby merged commit 72786ea into zarr-developers:main Jun 19, 2025
30 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the LMDBStore_DBMStore branch June 19, 2025 09:49
This was referenced Jun 19, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstansby dstansby dstansby approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DOC: deprecated stores
3 participants
@DimitriPapadopoulos @d-v-b @dstansby