Start applying ruff rules to notebooks (ruff 0.6+) #2115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
notebooks
branch
2 times, most recently
from
cc7e1f9 to
84b493f
Compare
|
I'm fine merging this in as is @DimitriPapadopoulos. We may also consider removing these notebooks from the repo as many of them are referencing data that we don't have access to. |
|
Let's remove the notebooks then. |
DimitriPapadopoulos
force-pushed
the
notebooks
branch
from
84b493f to
a83789c
Compare
DimitriPapadopoulos
force-pushed
the
notebooks
branch
from
a83789c to
b5644cd
Compare
DimitriPapadopoulos
force-pushed
the
notebooks
branch
from
b5644cd to
a723011
Compare
DimitriPapadopoulos
force-pushed
the
notebooks
branch
from
a723011 to
457cf8a
Compare
F401 imported but unused
F811 Redefinition of unused
W291 Trailing whitespace
W293 Blank line contains whitespace
I001 Import block is un-sorted or un-formatted
UP031 Use format specifiers instead of percent format
UP032 Use f-string instead of `format` call
UP033 Use `@functools.cache` instead of `@functools.lru_cache(maxsize=None)`
RUF010 Use explicit conversion flag
E402 Module level import not at top of cell
Many of them are referencing data that we don't have access to.
DimitriPapadopoulos
force-pushed
the
notebooks
branch
from
457cf8a to
8866195
Compare
dstansby
added
the
needs release notes
|
Superseded by #2897. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyter notebooks are now linted and formatted by default
TODO: