Skip to content

Schema dumps #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 14, 2024
Merged

Schema dumps #30

merged 12 commits into from
Jan 14, 2024

Conversation

peterfox
Copy link
Collaborator

Changes In Code

Mostly the Schema Dump import and export.
Adds a test for the Schema Dump system.
There is also some fixes and documentation improvements thrown in.

Issue ticket number / Business Case

Pointed out by #27 the schema dump functionality doesn't work. This should work

Checklist before requesting a review

  • I have written PHP tests.
  • I have updated the documentation in the readme where needed.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f3383bb) 88.23% compared to head (9edb310) 91.39%.

Files Patch % Lines
src/CockroachDbConnection.php 92.85% 1 Missing ⚠️
src/Schema/CockroachSchemaState.php 95.23% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #30      +/-   ##
============================================
+ Coverage     88.23%   91.39%   +3.16%     
- Complexity       26       32       +6     
============================================
  Files             6        7       +1     
  Lines            68       93      +25     
============================================
+ Hits             60       85      +25     
  Misses            8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfox peterfox force-pushed the feature/schema-dumps branch from 395b419 to 8734e43 Compare January 14, 2024 17:05
@peterfox peterfox merged commit aa42814 into main Jan 14, 2024
@peterfox peterfox deleted the feature/schema-dumps branch January 14, 2024 18:38
@peterfox peterfox mentioned this pull request Jan 14, 2024
4 tasks
@lucacri
Copy link

lucacri commented Feb 7, 2024

Hey! I think there is an error in the way the dump is created. The statements might not end with a semicolon

missing semicolon at end of statement: insert into "migrations"

I am going to try to fork it and fix it, then send a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants