generated from spatie/package-skeleton-laravel
-
-
Notifications
You must be signed in to change notification settings - Fork 5
Schema dumps #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Schema dumps #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #30 +/- ##
============================================
+ Coverage 88.23% 91.39% +3.16%
- Complexity 26 32 +6
============================================
Files 6 7 +1
Lines 68 93 +25
============================================
+ Hits 60 85 +25
Misses 8 8 ☔ View full report in Codecov by Sentry. |
395b419
to
8734e43
Compare
Hey! I think there is an error in the way the dump is created. The statements might not end with a semicolon
I am going to try to fork it and fix it, then send a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes In Code
Mostly the Schema Dump import and export.
Adds a test for the Schema Dump system.
There is also some fixes and documentation improvements thrown in.
Issue ticket number / Business Case
Pointed out by #27 the schema dump functionality doesn't work. This should work
Checklist before requesting a review