Skip to content

Implement artisan schema:dump #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kamil-michalak
Copy link
Contributor

@kamil-michalak kamil-michalak commented Dec 13, 2023

Changes In Code

  • I have added method to use ./artisan schema:dump which currently is not working with cockroach

Issue ticket number / Business Case

Checklist before requesting a review

  • I have written PHP tests.
  • I have updated the documentation in the readme where needed.
  • I have checked code styles, PHPStan etc. pass.
  • I have provided an issue/business case.

@peterfox
Copy link
Collaborator

peterfox commented Jan 3, 2024

@kamil-michalak sorry I'm a bit behind this. Would you be able to look at writing tests for this functionality at all?

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (d992b30) 88.23% compared to head (97b2753) 66.66%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/Schema/CockroachSchemaState.php 0.00% 22 Missing ⚠️
src/CockroachDbConnection.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main      #27       +/-   ##
=============================================
- Coverage     88.23%   66.66%   -21.57%     
- Complexity       26       30        +4     
=============================================
  Files             6        7        +1     
  Lines            68       90       +22     
=============================================
  Hits             60       60               
- Misses            8       30       +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterfox peterfox mentioned this pull request Jan 14, 2024
4 tasks
@peterfox
Copy link
Collaborator

Implemented in #30

@peterfox peterfox closed this Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants