This repository was archived by the owner on May 1, 2024. It is now read-only.
[CameraView] [iOS] Flash does not work fix #1563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
DO-NOT-MERGE
|
I'm pretty confident this works for the regular flash. It does crash when I set it to torch though. Torch comes on, but when I take a picture it crashes. |
|
OK I think I got it working for all scenarios now! 🎉 |
jfversluis
added
bug
|
Also brushed up the sample a bit. The right part switches between an Image and a MediaElement depending on a video or a photo is taken. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Switched setting the flash mode to after the camera is being initialised to make it work when it's set from XAML or anywhere before it is available. Additionally made an exception for the torch when taking a picture as that's not an "official" supported flash mode.
Bugs Fixed
API Changes
NA
Behavioral Changes
Nothing notable except that before it wasn't working or even crashing, now it all works!
PR Checklist
approved