[CameraView] [iOS] Flash does not work fix (#1563)

* Update CameraViewRenderer.ios.cs

* Update FormsCameraView.ios.cs

* Update FormsCameraView.ios.cs

* Brushed up sample

Author: jfversluis

samples/XCT.Sample/Pages/Views/CameraViewPage.xaml

@@ -6,15 +6,44 @@
     xmlns:pages="clr-namespace:Xamarin.CommunityToolkit.Sample.Pages"
     xmlns:xct="http://xamarin.com/schemas/2020/toolkit">
     <ScrollView>
-        <StackLayout>
-            <xct:CameraView
-                x:Name="cameraView"
-                CaptureMode="Video"
-                FlashMode="On"
-                HorizontalOptions="FillAndExpand"
-                MediaCaptured="CameraView_MediaCaptured"
-                OnAvailable="CameraView_OnAvailable"
-                VerticalOptions="FillAndExpand" />
+        <Grid RowDefinitions="300, Auto">
+            <Grid ColumnDefinitions="*, *" Grid.Row="0">
+                <xct:CameraView
+                    Grid.Column="0"
+                    x:Name="cameraView"
+                    CaptureMode="Photo"
+                    FlashMode="Off"
+                    HorizontalOptions="FillAndExpand"
+                    MediaCaptured="CameraView_MediaCaptured"
+                    OnAvailable="CameraView_OnAvailable"
+                    VerticalOptions="FillAndExpand" />
+                <Label
+                    Grid.Column="0"
+                    Text="Camera"
+                    HorizontalTextAlignment="Center"
+                    HorizontalOptions="FillAndExpand"
+                    VerticalOptions="End" />
+
+                <Image
+                    Grid.Column="1"
+                    x:Name="previewPicture"
+                    Aspect="AspectFit"
+                    BackgroundColor="LightGray" />
+
+                <xct:MediaElement
+                    Grid.Column="1"
+                    x:Name="previewVideo"
+                    Aspect="AspectFit"
+                    BackgroundColor="LightGray"
+                    IsVisible="false"/>
+                <Label
+                    Grid.Column="1"
+                    Text="Result"
+                    HorizontalTextAlignment="Center"
+                    HorizontalOptions="FillAndExpand"
+                    VerticalOptions="End" />
+            </Grid>
+            
 
             <StackLayout Grid.Row="1" Orientation="Horizontal">
                 <Label x:Name="zoomLabel" />
@@ -29,7 +58,7 @@
                     Value="1" />
             </StackLayout>
 
-            <StackLayout>
+            <StackLayout Grid.Row="2">
                 <Grid ColumnDefinitions="*, *" RowDefinitions="*,*">
                     <StackLayout
                         Grid.Row="0"
@@ -38,7 +67,7 @@
                         Orientation="Horizontal">
                         <Switch
                             Margin="0,0,5,0"
-                            IsToggled="True"
+                            IsToggled="False"
                             Toggled="VideoSwitch_Toggled" />
                         <Label Text="Video" />
                     </StackLayout>
@@ -60,24 +89,19 @@
                         Orientation="Horizontal">
                         <Switch
                             Margin="0,0,5,0"
-                            IsToggled="True"
+                            IsToggled="False"
                             Toggled="FlashSwitch_Toggled" />
                         <Label Text="Flash" />
                     </StackLayout>
                 </Grid>
 
                 <Button
                     x:Name="doCameraThings"
-                    Command="{Binding ShutterCommand, Source={x:Reference cameraView}}"
+                    Clicked="DoCameraThings_Clicked"
                     IsEnabled="False"
-                    Text="Start Recording" />
-                <Image
-                    x:Name="previewPicture"
-                    Aspect="AspectFit"
-                    BackgroundColor="LightGray"
-                    HeightRequest="250"
-                    IsVisible="False" />
+                    Text="Snap picture" />
+                
             </StackLayout>
-        </StackLayout>
+        </Grid>
     </ScrollView>
 </pages:BasePage>

samples/XCT.Sample/Pages/Views/CameraViewPage.xaml.cs

@@ -74,13 +74,16 @@ void CameraView_MediaCaptured(object? sender, MediaCapturedEventArgs e)
 				default:
 				case CameraCaptureMode.Default:
 				case CameraCaptureMode.Photo:
+					previewVideo.IsVisible = false;
 					previewPicture.IsVisible = true;
 					previewPicture.Rotation = e.Rotation;
 					previewPicture.Source = e.Image;
 					doCameraThings.Text = "Snap Picture";
 					break;
 				case CameraCaptureMode.Video:
 					previewPicture.IsVisible = false;
+					previewVideo.IsVisible = true;
+					previewVideo.Source = e.Video;
 					doCameraThings.Text = "Start Recording";
 					break;
 			}

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/CameraViewRenderer.ios.cs

@@ -29,11 +29,11 @@ protected override void OnElementChanged(ElementChangedEventArgs<CameraView> e)
 				Control.Available += OnAvailability;
 				Control.FinishCapture += FinishCapture;
 
-				Control.SwitchFlash(Element.FlashMode);
 				Control.SetBounds(Element.WidthRequest, Element.HeightRequest);
 				Control.VideoStabilization = Element.VideoStabilization;
 				Control.Zoom = (float)Element.Zoom;
 				Control.RetrieveCameraDevice(Element.CameraOptions);
+				Control.SwitchFlash(Element.FlashMode);
 			}
 
 			if (e.OldElement != null)

src/CommunityToolkit/Xamarin.CommunityToolkit/Views/CameraView/iOS/FormsCameraView.ios.cs

@@ -203,7 +203,13 @@ public async Task TakePhoto()
 					photoOutputConnection.VideoOrientation = previewLayer.Connection?.VideoOrientation ?? throw new NullReferenceException();
 
 				var photoSettings = AVCapturePhotoSettings.Create();
-				photoSettings.FlashMode = (AVCaptureFlashMode)flashMode;
+
+				// Torch is set somewhere different
+				if (flashMode != CameraFlashMode.Torch)
+				{
+					photoSettings.FlashMode = (AVCaptureFlashMode)flashMode;
+				}
+
 				photoSettings.IsHighResolutionPhotoEnabled = true;
 
 				var photoCaptureDelegate = new PhotoCaptureDelegate