Skip to content

feat: analytics for the registration flow - WPB-17530 #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 340 commits into from
Jul 24, 2025
Merged

feat: analytics for the registration flow - WPB-17530 #3184

merged 340 commits into from
Jul 24, 2025

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Jun 13, 2025 •
edited by github-actions bot
Loading

StoryWPB-17530 [iOS] New Registration Flows - Personal account countly tracking

Issue

This PR introduces 2 features:

  • track events for new registration that are defined in a Jira ticket
  • track events by account rather than by app

Testing

Event on Countly

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

caldrian and others added 30 commits June 10, 2025 11:24
@caldrian
undo certain changes
7719319
@KaterinaWire
add VerificationEmailCodeComponent
97c3908
@caldrian
use Journal in TrackingManager
9f99ae6
@caldrian
minor refactoring
5cf008d
@caldrian
delete AnalyticsServiceConfiguration.didUserGiveTrackingConsent
0b662c5
@caldrian
create CountlyConfiguration struct
5df0cd3
@caldrian
use new stencil
00e0dc9
@caldrian
fix tests
d179cbe
@caldrian
actually fix tests
d7a0016
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/anal…
fb27d33 
…ytics-setup-refactoring-WPB-17530
@caldrian
delete custom error type
295b562
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/anal…
16b127b 
…ytics-setup-refactoring-WPB-17530
@KaterinaWire
happy path
bf2ab31
@KaterinaWire
changes for PersonalAccountCreation screen
6307c58
@KaterinaWire
Merge branch 'develop' into feat/personal-account-creation-part1-WPB-…
d4a2881 
…17453
@KaterinaWire
clean up code resend
153bf12
@KaterinaWire
clean up
34a3a4b
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/anal…
a45aa9b 
…ytics-setup-refactoring-WPB-17530
@caldrian
format code
d2c3388
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/anal…
b4c5dcc 
…ytics-setup-refactoring-WPB-17530
@caldrian
fix build errors in WireSyncEngine
eef9a69
@KaterinaWire
Merge branch 'develop' into feat/personal-account-creation-part1-WPB-…
e6b527e 
…17453
@KaterinaWire
fix swiftLint issues
b57c9cc
@KaterinaWire
add error handling
e2151ed
@KaterinaWire
Merge branch 'develop' into feat/personal-account-creation-part1-WPB-…
9b9f3cf 
…17453
@KaterinaWire
fix API tests
9c1c348
@KaterinaWire
fix API tests
f861cb8
@KaterinaWire
fix VerificationEmailCodeView
f4aa318
@KaterinaWire
merge develop
e2d619c
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into chore/anal…
7473db9 
…ytics-setup-refactoring-WPB-17530
@caldrian caldrian requested a review from johnxnguyen July 23, 2025 15:20
johnxnguyen
johnxnguyen reviewed Jul 23, 2025
View reviewed changes
Copy link
Collaborator

@johnxnguyen johnxnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left come comments/questions

@caldrian caldrian changed the base branch from release/cycle-4.2 to develop July 24, 2025 10:57
caldrian added 9 commits July 24, 2025 12:57
@caldrian
add AnalyticsTrackingAvailabilityCheckerTests
abe1d80
@caldrian
feat: analytics for the registration flow - WPB-17530
64191ed
@caldrian
Merge branch 'feat/registration-flow-countly-WPB-17530' of github.com…
8f145a4 
…:wireapp/wire-ios into feat/registration-flow-countly-WPB-17530
@caldrian
feat: analytics for the registration flow - WPB-17530
c7bf408
@caldrian
Merge branch 'feat/registration-flow-countly-WPB-17530' of github.com…
bb0c423 
…:wireapp/wire-ios into feat/registration-flow-countly-WPB-17530
@caldrian
delete TODO
4f43adf
@caldrian
format code
9272fe1
@caldrian
Merge branch 'develop' of github.com:wireapp/wire-ios into feat/regis…
0d28d41 
…tration-flow-countly-WPB-17530

# Conflicts:
#	wire-ios-data-model/Source/Model/User/TrackingIDProvider.swift
@caldrian
revert snapshot reference image changes
5610abe
@caldrian caldrian enabled auto-merge July 24, 2025 13:44
@caldrian caldrian added this pull request to the merge queue Jul 24, 2025
Merged via the queue into develop with commit ca028c2 Jul 24, 2025
13 checks passed
@caldrian caldrian deleted the feat/registration-flow-countly-WPB-17530 branch July 24, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe left review comments

@samwyndham samwyndham samwyndham approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

Assignees

@caldrian caldrian

Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@caldrian @netbe @samwyndham @johnxnguyen @KaterinaWire @dmitrysimkin @jullianm