fix: revisit conditions to display channel creation option - WPB-18788

[jullianm]

WPB-18788 [iOS] Channel upgrade flow leads to already on a team

Issue

Context: on team user account, tapping on "New channel" to create a new channel ends up showing a banner to upgrade to a team although we're already in a team

Causes: Conditional checking was incomplete, user could not actually create a channel as feature config is either disabled / he doesn't have the channel permission to do so.

Solution: Conditional checking logic was revisited a bit in this PR:

• if user is a personal user, display new channel creation option -> tapping on it will show the personal to team migration banner
• if user is a team user and can create a channel, display new channel creation option -> tapping on it user will be able to create the channel
• if user is a team user and cannot create a channel -> don't show the new channel creation option

Testing

• login on a personal user account, see new channel creation option, tap -> banner to upgrade to a team should show up
• login on a team user account where channel feature config is disabled -> new channel creation option will not show up
• login on a team user account where channel feature config is enabled and user has the permission to create a channel -> user will be able to create a channel

Checklist

• Title contains a reference JIRA issue number like [WPB-XXX].
• Description is filled and free of optional paragraphs.
• Adds/updates automated tests.

---

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

• Make sure you use the API for UI elements that support large fonts.
• All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
• New UI elements have Accessibility strings for VoiceOver.

[github-actions]

Test Results

    2 files    293 suites   6m 3s ⏱️
1 836 tests 1 806 ✅ 27 💤 3 ❌
1 836 runs  1 809 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit df01193.

♻️ This comment has been updated with latest results.

[netbe]

LGTM;) even better if we can add a test for the logic