Skip to content

Update hot-module-replacement.md #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

AlenQi
Copy link

@AlenQi AlenQi commented Aug 31, 2017

add the '`',abide by the grammar

add the '`',abide by the grammar
@jsf-clabot
Copy link

jsf-clabot commented Aug 31, 2017

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@skipjack skipjack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@pierreneter
Copy link
Member

It will be fixed with d0791ac of #1562. And here is a PR after that PR, is this a coincidence?

@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

@pierreneter good catch, I just merged the other so let's close this. Thanks anyway for your contribution @AlenQi!

@skipjack skipjack closed this Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants