fix(hot-module-replacement): Fix and improve HMR management API #1562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skipjack
requested changes
Sep 1, 2017
| "unaccepted" | "accepted" | | ||
| "disposed" | "accept-errored" | | ||
| "self-accept-errored" | "self-accept-error-handler-errored", | ||
| moduleId: 4, // The module in questions. |
| - `onDisposed` (function(info)): Notifier for disposed modules | ||
| - `onErrored` (function(info)): Notifier for errors | ||
|
|
||
| The `info` object has this format: |
There was a problem hiding this comment.
Might rephrase as:
The
infoparameter will be an object containing the following values:
| 5: [4] | ||
| }, | ||
| error: new Error(...), // For errors: the thrown error | ||
| orginalError: new Error(...) // For self-accept-error-handler-errored: |
There was a problem hiding this comment.
Is this supposed to be originalError?
There was a problem hiding this comment.
Theoretically yes, but the typo is also in the source code. I try to fix it in the source.
skipjack
approved these changes
Sep 1, 2017
Ah ok, want me to hold off on merging until you release a patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In webpack 2
checkandapplyreturn Promises.There are more options.