Skip to content

fix: support devServer: false #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

feature #2947

Did you add tests for your changes?

WIP

If relevant, did you update the documentation?

WIP

Summary

WIP

Does this PR introduce a breaking change?

WIP

Other information

WIP

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (09bfb16) 90.59% compared to head (c23286b) 68.90%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #4045       +/-   ##
===========================================
- Coverage   90.59%   68.90%   -21.70%     
===========================================
  Files          22       21        -1     
  Lines        1702     1701        -1     
  Branches      491      491               
===========================================
- Hits         1542     1172      -370     
- Misses        160      529      +369     
Files Coverage Δ
packages/webpack-cli/src/webpack-cli.ts 72.08% <ø> (-20.56%) ⬇️
packages/serve/src/index.ts 73.50% <40.00%> (-5.97%) ⬇️

... and 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7817b6e...c23286b. Read the comment docs.

@alexander-akait
Copy link
Member Author

@snitin315 We should allow false for devServer in webpack, feel free to send a PR

@snitin315
Copy link
Member

Sure, I'll update in webpack

@alexander-akait alexander-akait marked this pull request as ready for review September 6, 2024 16:28
@alexander-akait alexander-akait requested a review from a team as a code owner September 6, 2024 16:28
Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexander-akait alexander-akait merged commit 83de0c8 into master Sep 9, 2024
46 checks passed
@alexander-akait alexander-akait deleted the fix-run-devServer-false branch September 9, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants