refactor: logic

Author: alexander-akait

packages/serve/src/index.ts

@@ -113,12 +113,6 @@ class ServeCommand {
           return;
         }
 
-        if ((compiler.options as WebpackDevServerOptions).devServer === undefined) {
-          await cli.runWebpack(webpackCLIOptions as any, false);
-
-          return;
-        }
-
         const servers: (typeof DevServer)[] = [];
 
         if (cli.needWatchStdin(compiler)) {
@@ -156,6 +150,12 @@ class ServeCommand {
         const usedPorts: number[] = [];
 
         for (const compilerForDevServer of compilersForDevServer) {
+          // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+          // @ts-ignore
+          if (compilerForDevServer.options.devServer === false) {
+            continue;
+          }
+
           // eslint-disable-next-line @typescript-eslint/no-explicit-any
           const args = devServerFlags.reduce((accumulator: Record<string, any>, flag: any) => {
             accumulator[flag.name] = flag;
@@ -244,6 +244,11 @@ class ServeCommand {
             process.exit(2);
           }
         }
+
+        if (servers.length === 0) {
+          cli.logger.error("No dev server configurations to run");
+          process.exit(2);
+        }
       },
     );
   }

packages/webpack-cli/src/webpack-cli.ts

@@ -2351,12 +2351,6 @@ class WebpackCLI implements IWebpackCLI {
           isMultiCompiler: Array.isArray(config.options),
         }),
       );
-
-      // Handle when `devServer` is false
-      // TODO improve type on the webpack side
-      if ((item as any).devServer === false) {
-        delete item.devServer;
-      }
     };
 
     if (Array.isArray(config.options)) {